FAQ
Edit report at http://pear.php.net/bugs/bug.php?id=18086&edit=1

ID: 18086
Updated by: gsherwood@squiz.net
Reported By: s dot marechal at jejik dot com
Summary: False positive. In ZEND standard, opening brace is
not always on a new line
-Status: Feedback
+Status: Wont fix
Type: Feature/Change Request
Package: PHP_CodeSniffer
Operating System: Windows Server 2003
Package Version: 1.2.2
PHP Version: 5.3.3
Assigned To: squiz
Roadmap Versions:
New Comment:

-Status: Feedback
+Status: Wont fix



Previous Comments:
------------------------------------------------------------------------

[2010-12-15 23:16:04] sandermarechal

You're right. It's the same as PEAR. Perhaps the ZEND standard should
use the PEAR function declaration sniff then instead of the Generic
BsdAllman sniff?

And thanks for the github link. That's going to be very useful!

------------------------------------------------------------------------

[2010-12-15 04:19:15] squiz

-Status: Bogus
+Status: Feedback
-Type: Bug
+Type: Feature/Change Request
Is this actually the same standard as PEAR?
http://pear.php.net/manual/en/standards.funcdef.php

if so, you can just include the PEAR/Functions/FunctionDeclarationSniff
into a ZF standard instead of writing new code.

Coincidently, found out about this last night:
https://github.com/dploeger/CodeSniffer_Zend_New

Maybe worth talking to this developer and helping out. He is using the
PEAR standard for most sniffs.

------------------------------------------------------------------------

[2010-12-06 14:49:15] sandermarechal

Patch added. I hope it's okay like this. I've never made a PEAR patch
before.

------------------------------------------------------------------------

[2010-12-06 14:48:21] sandermarechal

Added #patch
bug:18086;patch:zend-function-opening-brace-sniff;revision:1291646901;.

------------------------------------------------------------------------

[2010-12-05 22:56:48] squiz

Sorry it took me so long to reply. I got side-tracked with other work.

If you'd like to contribute a sniff, please attach it to this report and
I'll test and commit it as soon as possible.

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://pear.php.net/bugs/bug.php?id=18086

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 1 of 1 | next ›
Discussion Overview
grouppear-bugs @
categoriesphp
postedJan 14, '11 at 2:51a
activeJan 14, '11 at 2:51a
posts1
users1
websitepear.php.net

1 user in discussion

Gsherwood: 1 post

People

Translate

site design / logo © 2022 Grokbase