On Fri, Jun 01, 2012 at 07:12:43AM -0400, Sullivan Beck wrote:
I just released Locale-Codes-3.22 which contains the core modules
Locale::Country, Locale::Language, and Locale::Currency. The patch is
attached to this message.
I've applied this to blead as 75e3a58a54895854.

I noticed a couple of things in the patch. Firstly:

@@ -34,10 +34,11 @@ modify it under the same terms as Perl itself.

use strict;
use warnings;
+use utf8;
require 5.002;


$Locale::Codes::Data{'country'}{'id'} = '0282';

use utf8; isn't going to work as far back as 5.002 :-)
Presumably the require 5.002 should really be require 5.006; (or maybe later)
and most usefully would be immediately after use strict;
(as both warnings and utf8 date from 5.006)


@@ -93,9 +94,9 @@ $Locale::Codes::Retired{'country'}{'alpha-3'}{'code'} = {
$Locale::Codes::Retired{'country'}{'fips-10'}{'code'} = {
q(RN) => q(Saint Martin),
q(UC) => q(Curacao),
- q(RI) => q(Serbia),
- q(MJ) => q(Montenegro),
q(KV) => q(Kosovo),
+ q(MJ) => q(Montenegro),
+ q(RI) => q(Serbia),
q(TB) => q(Saint Barthelemy),
q(NN) => q(Sint Maarten),

There are a lot of diff hunks like this, where keys change order. It makes
it harder to spot what really changed. These files are all generated, aren't
they? Would it make sense to sort the keys for the generated output? I
realise that this will make 1 thunking great diff for the transition, but
after that one-off cost it should be much clearer.

Nicholas Clark

Search Discussions

Discussion Posts


Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 3 of 4 | next ›
Discussion Overview
groupperl5-porters @
postedJun 1, '12 at 11:12a
activeJun 4, '12 at 11:29a



site design / logo © 2021 Grokbase