FAQ
HIVE-11883 'transactional' table property for ACID should be case insensitive (Eugene Koifman, reviewed by Ashutosh Chauhan)


Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/f20a359d
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/f20a359d
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/f20a359d

Branch: refs/heads/branch-1
Commit: f20a359d77230b6c57120d8bb71ad700b1a7d4c2
Parents: 43e08a4
Author: Eugene Koifman <ekoifman@hortonworks.com>
Authored: Wed Sep 30 17:19:49 2015 -0700
Committer: Eugene Koifman <ekoifman@hortonworks.com>
Committed: Wed Sep 30 17:19:49 2015 -0700

----------------------------------------------------------------------
  .../java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java | 3 +++
  ql/src/test/queries/clientpositive/update_all_types.q | 2 +-
  ql/src/test/results/clientpositive/tez/update_all_types.q.out | 4 ++--
  ql/src/test/results/clientpositive/update_all_types.q.out | 4 ++--
  4 files changed, 8 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hive/blob/f20a359d/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
index 5864c35..6e82f41 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
@@ -12212,6 +12212,9 @@ public class SemanticAnalyzer extends BaseSemanticAnalyzer {
      if (!SessionState.get().getTxnMgr().supportsAcid()) return false;
      String tableIsTransactional =
          tab.getProperty(hive_metastoreConstants.TABLE_IS_TRANSACTIONAL);
+ if(tableIsTransactional == null) {
+ tableIsTransactional = tab.getProperty(hive_metastoreConstants.TABLE_IS_TRANSACTIONAL.toUpperCase());
+ }
      return tableIsTransactional != null && tableIsTransactional.equalsIgnoreCase("true");
    }


http://git-wip-us.apache.org/repos/asf/hive/blob/f20a359d/ql/src/test/queries/clientpositive/update_all_types.q
----------------------------------------------------------------------
diff --git a/ql/src/test/queries/clientpositive/update_all_types.q b/ql/src/test/queries/clientpositive/update_all_types.q
index 262a304..0229845 100644
--- a/ql/src/test/queries/clientpositive/update_all_types.q
+++ b/ql/src/test/queries/clientpositive/update_all_types.q
@@ -17,7 +17,7 @@ create table acid_uat(ti tinyint,
                   s string,
                   vc varchar(128),
                   ch char(36),
- b boolean) clustered by (i) into 2 buckets stored as orc TBLPROPERTIES ('transactional'='true');
+ b boolean) clustered by (i) into 2 buckets stored as orc TBLPROPERTIES ('TRANSACTIONAL'='TRUE');

  insert into table acid_uat
      select ctinyint,

http://git-wip-us.apache.org/repos/asf/hive/blob/f20a359d/ql/src/test/results/clientpositive/tez/update_all_types.q.out
----------------------------------------------------------------------
diff --git a/ql/src/test/results/clientpositive/tez/update_all_types.q.out b/ql/src/test/results/clientpositive/tez/update_all_types.q.out
index ca098fb..1cfa088 100644
--- a/ql/src/test/results/clientpositive/tez/update_all_types.q.out
+++ b/ql/src/test/results/clientpositive/tez/update_all_types.q.out
@@ -13,7 +13,7 @@ create table acid_uat(ti tinyint,
                   s string,
                   vc varchar(128),
                   ch char(36),
- b boolean) clustered by (i) into 2 buckets stored as orc TBLPROPERTIES ('transactional'='true')
+ b boolean) clustered by (i) into 2 buckets stored as orc TBLPROPERTIES ('TRANSACTIONAL'='TRUE')
  PREHOOK: type: CREATETABLE
  PREHOOK: Output: database:default
  PREHOOK: Output: default@acid_uat
@@ -32,7 +32,7 @@ create table acid_uat(ti tinyint,
                   s string,
                   vc varchar(128),
                   ch char(36),
- b boolean) clustered by (i) into 2 buckets stored as orc TBLPROPERTIES ('transactional'='true')
+ b boolean) clustered by (i) into 2 buckets stored as orc TBLPROPERTIES ('TRANSACTIONAL'='TRUE')
  POSTHOOK: type: CREATETABLE
  POSTHOOK: Output: database:default
  POSTHOOK: Output: default@acid_uat

http://git-wip-us.apache.org/repos/asf/hive/blob/f20a359d/ql/src/test/results/clientpositive/update_all_types.q.out
----------------------------------------------------------------------
diff --git a/ql/src/test/results/clientpositive/update_all_types.q.out b/ql/src/test/results/clientpositive/update_all_types.q.out
index ca098fb..1cfa088 100644
--- a/ql/src/test/results/clientpositive/update_all_types.q.out
+++ b/ql/src/test/results/clientpositive/update_all_types.q.out
@@ -13,7 +13,7 @@ create table acid_uat(ti tinyint,
                   s string,
                   vc varchar(128),
                   ch char(36),
- b boolean) clustered by (i) into 2 buckets stored as orc TBLPROPERTIES ('transactional'='true')
+ b boolean) clustered by (i) into 2 buckets stored as orc TBLPROPERTIES ('TRANSACTIONAL'='TRUE')
  PREHOOK: type: CREATETABLE
  PREHOOK: Output: database:default
  PREHOOK: Output: default@acid_uat
@@ -32,7 +32,7 @@ create table acid_uat(ti tinyint,
                   s string,
                   vc varchar(128),
                   ch char(36),
- b boolean) clustered by (i) into 2 buckets stored as orc TBLPROPERTIES ('transactional'='true')
+ b boolean) clustered by (i) into 2 buckets stored as orc TBLPROPERTIES ('TRANSACTIONAL'='TRUE')
  POSTHOOK: type: CREATETABLE
  POSTHOOK: Output: database:default
  POSTHOOK: Output: default@acid_uat

Search Discussions

Discussion Posts

Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 1 of 28 | next ›
Discussion Overview
groupcommits @
categorieshive, hadoop
postedOct 1, '15 at 12:42a
activeOct 2, '15 at 2:37a
posts28
users4
websitehive.apache.org

People

Translate

site design / logo © 2021 Grokbase