Abhijit Bagri updated HADOOP-4416:
----------------------------------
Attachment: HADOOP-4416-v3.patch
Thanks, Steve for reviewing the patch. I updated the patch with your comments.
Making trim() protected makes sense.
Strictly speaking, doing toLowerCase does break semantics. I would say that if you have a conf.getBoolean("something-TRUE", false), it is more likely a bug. I am leaving this out of the scope of this jira. I will file a separate issue on that.
Added test cases for default handling.
class names in Configuration are not resolved if the configuration value has a white space
-------------------------------------------------------------------------------------------
Key: HADOOP-4416
URL: https://issues.apache.org/jira/browse/HADOOP-4416
Project: Hadoop Core
Issue Type: Bug
Environment: all
Reporter: Alejandro Abdelnur
Assignee: Abhijit Bagri
Attachments: HADOOP-4416-v2.patch, HADOOP-4416-v3.patch, HADOOP-4416.patch
If an entry in the configuration used for a class contains spaces or enters before or after the {{getClass}} and {{getClasses}} methods fail to resolve the class.
For example:
{code}
<property>
<name>mapred.mapper.class</name>
<value>
com.foo.MyMapper
</value>
</property>
{code}
---------------------------------------------------------------------------------------------
Key: HADOOP-4416
URL: https://issues.apache.org/jira/browse/HADOOP-4416
Project: Hadoop Core
Issue Type: Bug
Environment: all
Reporter: Alejandro Abdelnur
Assignee: Abhijit Bagri
Attachments: HADOOP-4416-v2.patch, HADOOP-4416-v3.patch, HADOOP-4416.patch
If an entry in the configuration used for a class contains spaces or enters before or after the {{getClass}} and {{getClasses}} methods fail to resolve the class.
For example:
{code}
<property>
<name>mapred.mapper.class</name>
<value>
com.foo.MyMapper
</value>
</property>
{code}
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.