FAQ
@victor - great questions. thanks for pushing bug fixes back to the master
repo!
On Tuesday, May 7, 2013 9:14:26 AM UTC-5, Chris Hunt wrote:

Is there are convention regarding how many bug fixes are contained in a pull
request?
If issues aren't related, they are better in separate pull requests. This
benefits you because, if there's a conversation about one of your fixes,
all
your commits aren't trapped in a single pull request. Your stuff will get
merged faster. This benefits the maintainers because small pull requests
are
much easier to review and merge.

-Chris
--
Don't miss SpreeConf on May 20-21: http://spreeconf.com
Spree is hiring: http://spreecommerce.com/careers

Search Discussions

Discussion Posts

Previous

Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 3 of 4 | next ›
Discussion Overview
groupspree-user @
categoriesrubyonrails
postedMay 7, '13 at 10:26a
activeMay 8, '13 at 3:34a
posts4
users3
websitespreecommerce.com
irc#RubyOnRails

People

Translate

site design / logo © 2022 Grokbase