FAQ
https://codereview.appspot.com/37730043/diff/160001/ssh/client.go
File ssh/client.go (right):

https://codereview.appspot.com/37730043/diff/160001/ssh/client.go#newcode34
ssh/client.go:34: // Client returns a new SSH client connection using c
as the underlying transport.
This comment is above the wrong function now. Also, after the move,
NewClientConn will need a comment. It should explain the when a user
might want Client(), when NewClientConn() and when Dial().

https://codereview.appspot.com/37730043/diff/160001/ssh/connection.go
File ssh/connection.go (right):

https://codereview.appspot.com/37730043/diff/160001/ssh/connection.go#newcode1
ssh/connection.go:1: package ssh
Copyright header.

https://codereview.appspot.com/37730043/diff/160001/ssh/connection.go#newcode8
ssh/connection.go:8: // OpenChannelError is returned if the other side
rejects our
s/our/an/

https://codereview.appspot.com/37730043/diff/160001/ssh/connection.go#newcode19
ssh/connection.go:19: // Conn represents an SSH connection. It is equal
for server and
// Conn represents an SSH connection for both client and server roles.

https://codereview.appspot.com/37730043/diff/160001/ssh/connection.go#newcode116
ssh/connection.go:116: type ConnMetadata interface {
Unclear why this exists. Why not put the contents directly into Conn?

https://codereview.appspot.com/37730043/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 1 of 1 | next ›
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 11, '13 at 8:52p
activeDec 11, '13 at 8:52p
posts1
users1
websitegolang.org

1 user in discussion

Agl: 1 post

People

Translate

site design / logo © 2022 Grokbase