FAQ
LGTM with nits.


https://codereview.appspot.com/24250044/diff/80001/src/pkg/crypto/cipher/benchmark_test.go
File src/pkg/crypto/cipher/benchmark_test.go (right):

https://codereview.appspot.com/24250044/diff/80001/src/pkg/crypto/cipher/benchmark_test.go#newcode46
src/pkg/crypto/cipher/benchmark_test.go:46: buf := make([]byte, 1023)
On 2013/12/10 23:10:28, hanwen-google wrote:
AFAICT, the stream ciphers don't have padding. Am I missing something?
Sorry, brain fart. Was thinking that this was a block mode.

https://codereview.appspot.com/24250044/diff/80001/src/pkg/crypto/cipher/cfb.go
File src/pkg/crypto/cipher/cfb.go (right):

https://codereview.appspot.com/24250044/diff/80001/src/pkg/crypto/cipher/cfb.go#newcode15
src/pkg/crypto/cipher/cfb.go:15: // We can precompute a larger segment
of the keystream on
On 2013/12/10 23:10:28, hanwen-google wrote:
On 2013/12/10 18:18:10, agl1 wrote:
Is this a TODO?
perhaps? You think I should rather remove the comment? I'm not sure I want to
put my name on it.
In which case I think it's ok to keep the comment as is, but to move it
inside XORKeyStream.

https://codereview.appspot.com/24250044/diff/80001/src/pkg/crypto/cipher/ctr.go
File src/pkg/crypto/cipher/ctr.go (right):

https://codereview.appspot.com/24250044/diff/80001/src/pkg/crypto/cipher/ctr.go#newcode22
src/pkg/crypto/cipher/ctr.go:22: // ? do something for cipher with
blocksz > 512 ?
On 2013/12/10 23:10:28, hanwen-google wrote:
On 2013/12/10 18:18:10, agl1 wrote:
delete comment?
so I can stop worrying about ultra-large blocksizes for now?
Well, you could handle it in NewCTR by making the cap of |out| equal to
max(streamBufferSize, block.BlockSize()).

https://codereview.appspot.com/24250044/diff/80001/src/pkg/crypto/cipher/ctr.go#newcode54
src/pkg/crypto/cipher/ctr.go:54: // why not constant time?
On 2013/12/10 23:10:28, hanwen-google wrote:
On 2013/12/10 18:18:10, agl1 wrote:
because the counter values aren't secret dependent.
OK, but they are in GCM? (since gcmInc32 is constant time) (just
curious)

They're not secret in gcm either. The constant time code was probably
force of habit.

https://codereview.appspot.com/24250044/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Discussion Posts

Previous

Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 6 of 10 | next ›
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 10, '13 at 6:18p
activeDec 11, '13 at 10:34p
posts10
users4
websitegolang.org

4 users in discussion

Hanwen: 5 posts Dave Cheney: 2 posts Agl: 2 posts Agl: 1 post

People

Translate

site design / logo © 2022 Grokbase