FAQ
I assume you don't see a delete because Hg has file identity (in
contrast to Git), and I ran "hg mv"


https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go
File ssh/agent/agent.go (right):

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode6
ssh/agent/agent.go:6: Package agent implements a client to a ssh-agent
daemon.
On 2013/12/09 21:12:06, agl1 wrote:
s/a/an/
Done.

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode23
ssh/agent/agent.go:23: "code.google.com/p/gosshnew.agent/ssh"
On 2013/12/09 21:36:43, jpsugar wrote:
Why is this .agent?
oops! side product of my juggling around 5 CLs in parallel.

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode192
ssh/agent/agent.go:192: // List returns the identities known to the
agent.
On 2013/12/09 21:12:06, agl1 wrote:
The comment suggests that the function was going to be renamed, but it hasn't
been.
Done.

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode331
ssh/agent/agent.go:331: sig := Sig{}
On 2013/12/09 21:36:43, jpsugar wrote:
On 2013/12/09 21:12:06, agl1 wrote:
var sig Sig
Or remove the local type:
var sig struct { ... }
Done.

https://codereview.appspot.com/38940043/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Discussion Posts

Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 1 of 2 | next ›
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 10, '13 at 9:56a
activeDec 10, '13 at 9:57a
posts2
users1
websitegolang.org

1 user in discussion

Hanwen: 2 posts

People

Translate

site design / logo © 2021 Grokbase