FAQ
https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el
File cmd/oracle/oracle.el (right):

https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el#newcode128
cmd/oracle/oracle.el:128: (message nil))
On 2013/09/03 19:33:25, Dominik Honnef wrote:
I truly hate counting ) in lisp diffs; I'll assume they're right :)
You can assume the (manual) Emacs test in this directory passes before I
mail out each review.

https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el#newcode133
cmd/oracle/oracle.el:133: (set-window-point w (point-min))))))
On 2013/09/03 19:33:25, Dominik Honnef wrote:
If you want you can use goto-char now, before the display-buffer, if
set-window-point causes some cognitive overhead.
set-window-point is the logically right thing here: I want to move the
scrollbar, not the point.

https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el#newcode172
cmd/oracle/oracle.el:172: (defun go-oracle-peers ()
On 2013/09/03 19:33:25, Dominik Honnef wrote:
Is this supposed to be part of this CL?
Yes; it makes the command names systematic (go-oracle-xxx) which makes
the documentation simpler.

I've updated the CL description.

https://codereview.appspot.com/13388044/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Discussion Posts

Previous

Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 3 of 4 | next ›
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 3, '13 at 7:25p
activeSep 3, '13 at 7:41p
posts4
users2
websitegolang.org

2 users in discussion

Adonovan: 3 posts Dominik Honnef: 1 post

People

Translate

site design / logo © 2022 Grokbase