FAQ
I think I'll manage the fixes, I'll commit in a few hours, just let me
finish up something first.

Btw, there's one slight design change I've added since the review
request: instead of passing in "hash-maker" functions, I've changed to
the crypto.Hash enums:

hkdf.New(sha1.New, ...) -> hkdf.New(crypto.SHA1, ...)

Which design do you prefer? The original or the crypto-enum one? (the
latter is available at
https://github.com/karalabe/iris/blob/master/crypto/hkdf/hkdf.go ).

PS: Yes I've signed the CLA (at least the digital version)

https://codereview.appspot.com/7474049/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Discussion Posts

Previous

Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 3 of 4 | next ›
Discussion Overview
groupgolang-dev @
categoriesgo
postedMar 12, '13 at 3:12p
activeMar 12, '13 at 6:40p
posts4
users3
websitegolang.org

3 users in discussion

Peterke: 2 posts Agl: 1 post Adam Langley: 1 post

People

Translate

site design / logo © 2022 Grokbase