FAQ
LGTM modulo these comments.


https://codereview.appspot.com/6553059/diff/24001/src/pkg/exp/inotify/inotify_linux.go
File src/pkg/exp/inotify/inotify_linux.go (right):

https://codereview.appspot.com/6553059/diff/24001/src/pkg/exp/inotify/inotify_linux.go#newcode92
src/pkg/exp/inotify/inotify_linux.go:92: w.add("/", IN_DELETE_SELF)
What about handling the error here ?

https://codereview.appspot.com/6553059/diff/24001/src/pkg/exp/inotify/inotify_linux.go#newcode109
src/pkg/exp/inotify/inotify_linux.go:109: w.mu.Unlock()
it is fine to use defer here, the cost is minimal.

https://codereview.appspot.com/6553059/diff/24001/src/pkg/exp/inotify/inotify_linux.go#newcode112
src/pkg/exp/inotify/inotify_linux.go:112:
// add adds path to the watched file set. The caller must have already
locked w.mu.

https://codereview.appspot.com/6553059/diff/24001/src/pkg/exp/inotify/inotify_linux.go#newcode149
src/pkg/exp/inotify/inotify_linux.go:149: w.mu.Unlock()
ditto

https://codereview.appspot.com/6553059/diff/24001/src/pkg/exp/inotify/inotify_linux.go#newcode152
src/pkg/exp/inotify/inotify_linux.go:152:
see comment on // add

https://codereview.appspot.com/6553059/diff/24001/src/pkg/exp/inotify/inotify_linux.go#newcode156
src/pkg/exp/inotify/inotify_linux.go:156: return
errors.New(fmt.Sprintf("can't remove non-existent inotify watch for:
%s", path))
fmt.Errorf might be simpler here.

https://codereview.appspot.com/6553059/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Discussion Posts

Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 1 of 2 | next ›
Discussion Overview
groupgolang-dev @
categoriesgo
postedFeb 17, '13 at 1:01a
activeFeb 17, '13 at 1:25a
posts2
users2
websitegolang.org

2 users in discussion

Dave: 1 post Mbnull Org: 1 post

People

Translate

site design / logo © 2022 Grokbase