On 2013/01/03 15:29:31, dvyukov wrote:
Hello mailto:golang-dev@googlegroups.com,
I'd like you to review this change to
https://dvyukov%2540google.com%40code.google.com/p/go/
Hello mailto:golang-dev@googlegroups.com,
I'd like you to review this change to
https://dvyukov%2540google.com%40code.google.com/p/go/
previous patch.
Machine: amd64/linux on i5-3470 CPU.
Before (tip d0d76b7fb219):
Rendering took 2m 34.5s
Sys: 85928184
StackInuse: 102400
StackSys: 31981568
After (tip d0d76b7fb219 + issue7029044_6007.diff):
Rendering took 2m 35.2s
Sys: 55128064
StackInuse: 12885004288
StackSys: 2621440
This time the actual runtime.MemStats numbers instead of staring at
process' RES (resident memory size). Rendering time is similar (less
than 1% difference is not statistically significant). Oh and this time I
was using 50 rays per pixel instead of 100, just to make tests quicker.
Also note the anomally high StackInuse number in your patch. Is it a
miscalculation?
https://codereview.appspot.com/7029044/