[golang-dev] code review 6942050: sql: adds test for fix in issue 4433. (issue 6942050)

[golang-dev] code review 6942050: sql: adds test for fix in issue 4433. (issue 6942050)

	Bradfitz
	Dec 14, 2012 at 5:00 pm

*** Submitted as
https://code.google.com/p/go/source/detail?r=de94dfa4fa4a ***

database/sql: adds test for fix in issue 4433.

Tests that here should be automatic retries if a database
driver's connection returns ErrBadConn on Begin. See
"TestTxErrBadConn" in sql_test.go

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/6942050

Committer: Brad Fitzpatrick <bradfitz@golang.org>

https://codereview.appspot.com/6942050/

Search Discussions

James Chalfant: Reviewers: golang-dev_googlegroups.com, Message: Hello [email protected] , I'd like you to review this change to https://code.google.com/p/go Description: sql: adds test for fix in issue 4433. Tests that here should be automatic retries if a database driver's connection returns ErrBadConn on Begin. See "TestTxErrBadConn" in sql_test.go Please review this at https://codereview.appspot.com/6942050/ Affected files: M src/pkg/database/sql/fakedb_test.go M src/pkg/database/sql/sql_test.go Index

Follow ups

Brad Fitzpatrick: LGTM Thanks! I changed the commit message before submitting ("database/sql: ..."), blank line after, and wrapped body.

Discussion Navigation

view	thread \| post
posts	‹ prev \| 2 of 3 \| next ›

Discussion Overview

font	variable	Hotkey: f
user style	avatars	Hotkey: a