FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go


Description:
database/sql: Alter *DB.begin to return driver.ErrBadConn when
driver.Conn.Begin returns driver.ErrBadConn
Fixes issue 4433

Please review this at https://codereview.appspot.com/6845094/

Affected files:
M src/pkg/database/sql/sql.go


Index: src/pkg/database/sql/sql.go
===================================================================
--- a/src/pkg/database/sql/sql.go
+++ b/src/pkg/database/sql/sql.go
@@ -426,7 +426,7 @@
txi, err := ci.Begin()
if err != nil {
db.putConn(ci, err)
- return nil, fmt.Errorf("sql: failed to Begin transaction: %v", err)
+ return nil, err
}
return &Tx{
db: db,

Search Discussions

Discussion Posts

Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 1 of 4 | next ›
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 13, '12 at 1:28a
activeDec 14, '12 at 8:19a
posts4
users2
websitegolang.org

2 users in discussion

James Chalfant: 2 posts Bradfitz: 2 posts

People

Translate

site design / logo © 2022 Grokbase