[golang-dev] Re: code review 6905057: os: Improve the accuracy of os.Chtimes (issue 6905057)

[golang-dev] Re: code review 6905057: os: Improve the accuracy of os.Chtimes (issue 6905057)

	Nickcw
	Dec 13, 2012 at 5:00 pm

Hello golang-dev@googlegroups.com, alex.brainman@gmail.com,
rsc@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

https://codereview.appspot.com/6905057/

Search Discussions

Discussion Posts

Alex Brainman: LGTM Leaving for Brad to submit once you have made his changes. Alex https://codereview.appspot.com/6905057/

Follow ups

Nickcw: https://codereview.appspot.com/6905057/diff/21001/src/pkg/syscall/syscall_bsd.go https://codereview.appspot.com/6905057/diff/21001/src/pkg/syscall/syscall_bsd.go#newcode612 https://codereview.appspot.com/6905057/diff/21001/src/pkg/syscall/syscall_bsd.go#newcode614 I've fixed both of those. I note that there are lots of other instances of (err error) in that file which could also be changed, but I haven't done so https://codereview.appspot.com/6905057/
Brad Fitzpatrick: Nick, I don't see a CLA on file for you. See http://golang.org/doc/contribute.html#copyright Once a CLA is submitted, let me know, then I can submit this CL.
Bradfitz: *** Submitted as https://code.google.com/p/go/source/detail?r=b7482cb67996 *** os: Improve the accuracy of os.Chtimes I've been writing some code which involves syncing files (like rsync) and it became apparent that under Linux I could read modification times (os.Lstat) with nanosecond precision but only write them with microsecond precision. This difference in precision is rather annoying when trying to discover whether files need syncing or not! I've patched syscall and os to increases the

Related Discussions

Discussion Navigation

view	thread \| post
posts	‹ prev \| 2 of 5 \| next ›

Discussion Overview

group	golang-dev @
categories	go
posted	Dec 13, '12 at 12:51a
active	Dec 13, '12 at 9:02p
posts	5
users	3
website	golang.org

font	variable	Hotkey: f
user style	avatars	Hotkey: a

[golang-dev] Re: code review 6905057: os: Improve the accuracy of os.Chtimes (issue 6905057)

Search Discussions

Discussion Posts

Related Discussions

3 users in discussion