On 2012/12/12 19:52:38, bradfitz wrote:
LGTM
but should wait on Alex for Windows.
LGTM
but should wait on Alex for Windows.
https://codereview.appspot.com/6905057/diff/21001/src/pkg/syscall/syscall_bsd.go
File src/pkg/syscall/syscall_bsd.go (right):
https://codereview.appspot.com/6905057/diff/21001/src/pkg/syscall/syscall_bsd.go#newcode612
src/pkg/syscall/syscall_bsd.go:612: // TODO: The BSDs can do utimensat with
SYS_UTIMENSAT but it isn't supported by darwin
move the TODO inside the function. where you have it now will make it render as
documentation on the function in godoc.
SYS_UTIMENSAT but it isn't supported by darwin
move the TODO inside the function. where you have it now will make it render as
documentation on the function in godoc.
https://codereview.appspot.com/6905057/diff/21001/src/pkg/syscall/syscall_bsd.go#newcode614
src/pkg/syscall/syscall_bsd.go:614: func UtimesNano(path string, ts
[]Timespec)
(err error) {
drop the named result parameter stutter. just "error" works.
I've fixed both of those.[]Timespec)
(err error) {
drop the named result parameter stutter. just "error" works.
I note that there are lots of other instances of (err error) in that
file which could also be changed, but I haven't done so
https://codereview.appspot.com/6905057/
