[golang-dev] Re: code review 6905057: os: Improve the accuracy of os.Chtimes (issue 6905057)

[golang-dev] Re: code review 6905057: os: Improve the accuracy of os.Chtimes (issue 6905057)

	Nickcw
	Dec 12, 2012 at 1:07 pm

Hello golang-dev@googlegroups.com, alex.brainman@gmail.com,
rsc@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

https://codereview.appspot.com/6905057/

Search Discussions

Discussion Posts

Follow ups

Nickcw: https://codereview.appspot.com/6905057/diff/13001/src/pkg/syscall/syscall_bsd.go https://codereview.appspot.com/6905057/diff/13001/src/pkg/syscall/syscall_bsd.go#newcode615 I have updated the patch with this change and restested it on linux, os x and windows https://codereview.appspot.com/6905057/
Bradfitz: LGTM but should wait on Alex for Windows. https://codereview.appspot.com/6905057/diff/21001/src/pkg/syscall/syscall_bsd.go File src/pkg/syscall/syscall_bsd.go (right): https://codereview.appspot.com/6905057/diff/21001/src/pkg/syscall/syscall_bsd.go#newcode612 src/pkg/syscall/syscall_bsd.go:612: // TODO: The BSDs can do utimensat with SYS_UTIMENSAT but it isn't supported by darwin move the TODO inside the function. where you have it now will make it render as documentation on the function in

Related Discussions

Discussion Navigation

view	thread \| post
posts	‹ prev \| 1 of 3 \| next ›

Discussion Overview

group	golang-dev @
categories	go
posted	Dec 12, '12 at 1:07p
active	Dec 12, '12 at 7:52p
posts	3
users	2
website	golang.org

font	variable	Hotkey: f
user style	avatars	Hotkey: a

[golang-dev] Re: code review 6905057: os: Improve the accuracy of os.Chtimes (issue 6905057)

Search Discussions

Discussion Posts

Related Discussions

2 users in discussion