[golang-dev] code review 6922050: go.net/proxy: correctly sets IPv4 addresses in socks5 r... (issue 6922050)

[golang-dev] code review 6922050: go.net/proxy: correctly sets IPv4 addresses in socks5 r... (issue 6922050)

	Raptium
	Dec 12, 2012 at 2:06 pm

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

https://codereview.appspot.com/6922050/

Search Discussions

Raptium: Reviewers: golang-dev_googlegroups.com, Message: Hello [email protected] , I'd like you to review this change to https://code.google.com/p/go.net Description: go.net/proxy: correctly sets IPv4 addresses in socks5 request now net.ParseIP(host) always returns a 16-byte array, we should convert it into 4-byte array before copy it to the IP field if it is a IPv4 address. Please review this at https://codereview.appspot.com/6922050/ Affected files: M proxy/socks5.go Index: proxy/socks5.go

Follow ups

Rsc: A test would be nice but I'm unfamiliar with this repo. Do we have tests for this package? https://codereview.appspot.com/6922050/diff/2002/proxy/socks5.go File proxy/socks5.go (right): https://codereview.appspot.com/6922050/diff/2002/proxy/socks5.go#newcode147 proxy/socks5.go:147: buf = append(buf, []byte(ipv4)...) ip = ipv4 and then the append can be done below where it used to be. Also the []byte() conversion is not necessary (I know it was in the original)

Discussion Navigation

view	thread \| post
posts	‹ prev \| 2 of 3 \| next ›

Discussion Overview

font	variable	Hotkey: f
user style	avatars	Hotkey: a