Grokbase
›
Groups
›
Go
›
golang-dev
›
December 2012
FAQ
Badges
Users
Groups
[golang-dev] code review 6869060: container/heap: Simplify the example. (issue 6869060)
Gri
Dec 4, 2012 at 9:37 pm
LGTM
thanks.
https://codereview.appspot.com/6869060/
reply
Tweet
Search Discussions
Search
All Groups
golang-dev
Discussion Posts
Previous
Schulze
: Reviewers: golang-dev_googlegroups.com, Message: Hello [email protected] , I'd like you to review this change to https://code.google.com/p/go Description: container/heap: Simplify the example. Using append simplifies the code and makes it work if the initial capacity of the slice is smaller than the number of items pushed. Please review this at https://codereview.appspot.com/6869060/ Affected files: M src/pkg/container/heap/example_test.go Index: src/pkg/container/heap/example_test.go
Follow ups
Gri
: *** Submitted as https://code.google.com/p/go/source/detail?r=64847a27cdd5 *** container/heap: Simplify the example. Using append simplifies the code and makes it work if the initial capacity of the slice is smaller than the number of items pushed. R=golang-dev, gri CC=golang-dev https://codereview.appspot.com/6869060 Committer: Robert Griesemer < [email protected] > https://codereview.appspot.com/6869060/
Related Discussions
[golang-dev] Re: code review 6872047: go.talks/present: simplify table of contents template (issue 6872047)
[golang-dev] code review 6875044: net: simplify ListenTCP (issue 6875044)
[golang-dev] code review 6872047: go.talks/present: simplify table of contents template (issue 6872047)
[golang-dev] code review 6822059: gofmt: simplify slices of the form s[a : len(s)] to s[a:] (issue 6822059)
[golang-dev] openbsd-amd64 broken by net: simplify ListenTCP
[golang-dev] Re: code review 6613064: container/heap: optimization in case heap has many dupl... (issue 6613064)
[golang-dev] code review 6613064: container/heap: optimization in case heap has many dupl... (issue 6613064)
[golang-dev] netbsd-amd64-bsiegert broken by container/heap: optimization in case heap has many duplicates
[golang-dev] container/heap opt
Re: [golang-dev] knob proposal: tweaking MHeap_Scavenger period
Discussion Navigation
view
thread
|
post
posts
‹ prev
|
2 of 3
|
next ›
Discussion Overview
group
golang-dev
@
categories
go
posted
Dec 4, '12 at 8:59p
active
Dec 4, '12 at 10:11p
posts
3
users
2
website
golang.org
Preferences
font
variable
Hotkey: f
user style
avatars
Hotkey: a
2 users in discussion
Gri (2)
Schulze (1)
Content
Home
Groups & Organizations
People
Users
Badges
Support
Welcome
FAQ
Contact Us
Translate
site design / logo © 2022 Grokbase