[golang-dev] code review 6842078: bufio: Optimize (*Writer).ReadFrom when the buffer is n... (issue 6842078)

[golang-dev] code review 6842078: bufio: Optimize (*Writer).ReadFrom when the buffer is n... (issue 6842078)

	Mchaten
	Nov 22, 2012 at 3:32 am

Hello golang-dev@googlegroups.com, dave@cheney.net, bradfitz@golang.org
(cc: golang-dev@googlegroups.com, nigeltao@golang.org),

Please take another look.

http://codereview.appspot.com/6842078/

Search Discussions

Discussion Posts

Dave Cheney: Can you add a test that demonstrates your change prevents the infinite loop in ReadAll ?

Follow ups

Mchaten: Hello [email protected] , dave@cheney.net, [email protected] (cc: [email protected] , [email protected] ), Please take another look. http://codereview.appspot.com/6842078/
Bradfitz: For a CL about optimizing, you should probably include a BenchmarkFoo function. https://codereview.appspot.com/6842078/diff/7006/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): https://codereview.appspot.com/6842078/diff/7006/src/pkg/bufio/bufio.go#newcode572 src/pkg/bufio/bufio.go:572: fillFlush := func() error { I'd make this be a (private) method on *Writer instead, even if it has to take an explicit (rather than closed-over) io.Reader argument. Then you can also document its

Related Discussions

Discussion Navigation

view	thread \| post
posts	‹ prev \| 9 of 11 \| next ›

Discussion Overview

group	golang-dev @
categories	go
posted	Nov 21, '12 at 1:42a
active	Nov 26, '12 at 2:58a
posts	11
users	3
website	golang.org

font	variable	Hotkey: f
user style	avatars	Hotkey: a

[golang-dev] code review 6842078: bufio: Optimize (*Writer).ReadFrom when the buffer is n... (issue 6842078)

Search Discussions

Discussion Posts

Related Discussions

3 users in discussion