[golang-dev] code review 6842078: bufio: Optimize (*Writer).ReadFrom when the buffer is n... (issue 6842078)

[golang-dev] code review 6842078: bufio: Optimize (*Writer).ReadFrom when the buffer is n... (issue 6842078)

	Mchaten
	Nov 22, 2012 at 2:40 am

On 2012/11/21 02:01:09, dfc wrote:
They shouldn't fail on an unmodified version. The modifications make

so the test readers and writers behave properly after returning an

err.

Without those changes io.ReadAll never fails, causing an infinite

loop.

Is it possible to add a test for that condition ?

Can you be more specific on the exact condition to test?

https://codereview.appspot.com/6842078/

Search Discussions

Mchaten: Depends on how you look it. I view this comment as explaining the entire if block, not just the != 0 block, but I can easily see the opposite. https://codereview.appspot.com/6842078/diff/5001/src/pkg/bufio/bufio.go#newcode581 This is a bug that the tests are not catching. I'm adding tests for this section now. Thank you for catching this. https://codereview.appspot.com/6842078/diff/5001/src/pkg/bufio/bufio.go#newcode612 I touch on this earlier in the code, should I repeat the comment?

Follow ups

Discussion Navigation

view	thread \| post
posts	‹ prev \| 7 of 11 \| next ›

Discussion Overview

font	variable	Hotkey: f
user style	avatars	Hotkey: a