[golang-dev] code review 6820114: crypto/x509: implement EncryptPEMBlock (issue 6820114)

[golang-dev] code review 6820114: crypto/x509: implement EncryptPEMBlock (issue 6820114)

	Adam Langley
	Nov 8, 2012 at 2:04 pm

Moving today. Reviews will be delayed I'm afraid.

On Nov 8, 2012 8:41 AM, wrote:

Hello agl@chromium.org (cc: golang-dev@googlegroups.com),

Please take another look.

http://codereview.appspot.com/**6820114/<http://codereview.appspot.com/6820114/>

Search Discussions

Rogpeppe: Hello [email protected] (cc: [email protected] ), Please take another look. http://codereview.appspot.com/6820114/

Follow ups

Agl: https://codereview.appspot.com/6820114/diff/6006/src/pkg/crypto/x509/pem_decrypt.go File src/pkg/crypto/x509/pem_decrypt.go (right): https://codereview.appspot.com/6820114/diff/6006/src/pkg/crypto/x509/pem_decrypt.go#newcode95 src/pkg/crypto/x509/pem_decrypt.go:95: return nil, errors.New("x509: wrong IV size") s/wrong/incorrect/ https://codereview.appspot.com/6820114/diff/6006/src/pkg/crypto/x509/pem_decrypt.go#newcode145 src/pkg/crypto/x509/pem_decrypt.go:145: func EncryptPEMBlock(blockType
Rogpeppe: Hello [email protected] , agl@golang.org (cc: [email protected] ), Please take another look. http://codereview.appspot.com/6820114/
Agl: LGTM https://codereview.appspot.com/6820114/

Discussion Navigation

view	thread \| post
posts	‹ prev \| 3 of 8 \| next ›

Discussion Overview

font	variable	Hotkey: f
user style	avatars	Hotkey: a