On 2012/11/06 22:04:24, dfc wrote:
Looks pretty good to me as well. I'll run some benchmarks on 32 bit platforms
once mine get through building the overnight changes.
Looks pretty good to me as well. I'll run some benchmarks on 32 bit platforms
once mine get through building the overnight changes.
https://codereview.appspot.com/6820096/diff/4002/src/pkg/crypto/sha1/sha1block.go
File src/pkg/crypto/sha1/sha1block.go (right):
https://codereview.appspot.com/6820096/diff/4002/src/pkg/crypto/sha1/sha1block.go#newcode26
src/pkg/crypto/sha1/sha1block.go:26: j := i * 4
j := i << 2 avoids the imul on intel. The compiler should be smarter
about this.j := i << 2 avoids the imul on intel. The compiler should be smarter
I tried changing the variables to unsigned to see if it would change
anything. I also tried adding in the shift instead of the mult, but
neither of these two changes affected the results of my benchmarks. I
think it would be safe to leave this alone for now.
https://codereview.appspot.com/6820096/
