[golang-dev] Re: code review 6553059: exp/inotify: cleanup ignored watch (issue 6553059)

[golang-dev] Re: code review 6553059: exp/inotify: cleanup ignored watch (issue 6553059)

	Mbnull Org
	Nov 1, 2012 at 9:01 pm

Hello golang-dev@googlegroups.com, dave@cheney.net, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

http://codereview.appspot.com/6553059/

Search Discussions

Discussion Posts

Rsc: https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux.go File src/pkg/exp/inotify/inotify_linux.go (right): https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux.go#newcode156 src/pkg/exp/inotify/inotify_linux.go:156: n, err := syscall.Read(w.fd, buf[0:]) If this only happens when closing the watcher, I would solve this by doing an InotifyAddWatch to unblock the read. :-) https://codereview.appspot.com/6553059/

Follow ups

Related Discussions

Discussion Navigation

view	thread \| post
posts	‹ prev \| 2 of 4 \| next ›

Discussion Overview

group	golang-dev @
categories	go
posted	Nov 1, '12 at 6:46p
active	Nov 1, '12 at 9:21p
posts	4
users	2
website	golang.org

font	variable	Hotkey: f
user style	avatars	Hotkey: a

[golang-dev] Re: code review 6553059: exp/inotify: cleanup ignored watch (issue 6553059)

Search Discussions

Discussion Posts

Related Discussions

2 users in discussion