Grokbase
›
Groups
›
Go
›
golang-dev
›
October 2012
FAQ
Badges
Users
Groups
[golang-dev] code review 6815061: cmd/gc: fix inlining bug with local variables. (issue 6815061)
Russ Cox
Nov 1, 2012 at 5:16 pm
LGTM
Thanks! I think I just ran into this yesterday.
reply
Tweet
Search Discussions
Search
All Groups
golang-dev
Discussion Posts
Previous
Remyoudompheng
: Reviewers: rsc, lvd, golang-dev_googlegroups.com, Message: Hello [email protected] , lvd@google.com, [email protected] (cc: [email protected] ), I'd like you to review this change to https://go.googlecode.com/hg/ Description: cmd/gc: fix inlining bug with local variables. Fixes issue 4323. Please review this at http://codereview.appspot.com/6815061/ Affected files: M src/cmd/gc/inl.c A test/fixedbugs/issue4323.go Index: src/cmd/gc/inl.c
Follow ups
Remyoudompheng
: *** Submitted as http://code.google.com/p/go/source/detail?r=2da23e50774a *** cmd/gc: fix inlining bug with local variables. Fixes issue 4323. R=rsc, lvd, golang-dev CC=golang-dev http://codereview.appspot.com/6815061 http://codereview.appspot.com/6815061/
Related Discussions
[golang-dev] Re: code review 6800043: cmd/gc: inlining functions with local variables (issue 6800043)
[golang-dev] code review 6800043: cmd/gc: inlining functions with local variables (issue 6800043)
[golang-dev] linux-amd64-race broken by cmd/gc: inlining functions with local variables
[golang-dev] Re: code review 6823044: misc/vim: fix reimport guard and remove K mapping. (issue 6823044)
[golang-dev] Re: code review 6741051: cmd/go: invoke gcc -print-libgcc-file-name only once (issue 6741051)
[golang-dev] code review 6816100: cmd/gc: annotate local variables with unique ids for in... (issue 6816100)
[golang-dev] Re: code review 5787055: cmd/go: local import fixes (issue 5787055)
[golang-dev] Re: code review 6525048: net: protocol specific listen functions return a proper... (issue 6525048)
[golang-dev] Re: code review 6499121: syscall: attempt to find error message in "local" langu... (issue 6499121)
[golang-dev] code review 6499121: syscall: attempt to find error message in "local" langu... (issue 6499121)
Discussion Navigation
view
thread
|
post
posts
‹ prev
|
2 of 3
|
next ›
Discussion Overview
group
golang-dev
@
categories
go
posted
Oct 31, '12 at 8:54p
active
Nov 1, '12 at 5:59p
posts
3
users
2
website
golang.org
Preferences
font
variable
Hotkey: f
user style
avatars
Hotkey: a
2 users in discussion
Remyoudompheng (2)
Russ Cox (1)
Content
Home
Groups & Organizations
People
Users
Badges
Support
Welcome
FAQ
Contact Us
Translate
site design / logo © 2022 Grokbase