[golang-dev] code review 6632044: crypto/hmac: add Verify function. (issue 6632044) - Grokbase

Grokbase › Groups › Go › golang-dev › October 2012

FAQ

[golang-dev] code review 6632044: crypto/hmac: add Verify function. (issue 6632044)

	Rsc
	Oct 9, 2012 at 11:57 pm

LGTM

It's fine to leave Sign and Verify out.

https://codereview.appspot.com/6632044/

Search Discussions

Discussion Posts

Previous

Adam Langley: I quite like that too, but I worry that it precludes avoiding the allocation each time when calling Sum. Without this function, users would are verifying many MACs can reuse storage. But, since escape-analysis isn't going to work through the interface, I think this would have to allocate every time. Cheers AGL

Follow ups

Agl: *** Submitted as http://code.google.com/p/go/source/detail?r=18dffd0c07b2 *** crypto/hmac: add Equal function. It was suggested that it's too easy to use crypto/hmac insecurely and I think that has some merit. This change adds a Equal function to make it obvious that MAC values should be compared in constant time. R=rsc, max CC=golang-dev http://codereview.appspot.com/6632044 http://codereview.appspot.com/6632044/

Related Discussions

Discussion Navigation

view	thread \| post
posts	‹ prev \| 6 of 7 \| next ›

Discussion Overview

group	golang-dev @
categories	go
posted	Oct 8, '12 at 6:36p
active	Oct 11, '12 at 7:28p
posts	7
users	3
website	golang.org

3 users in discussion

Content

People

Users
Badges

Support

Translate

site design / logo © 2023 Grokbase