FAQ
https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux.go
File src/pkg/exp/inotify/inotify_linux.go (right):

https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux.go#newcode200
src/pkg/exp/inotify/inotify_linux.go:200: if event.Mask&IN_IGNORED != 0
{
^ gofmt ?

https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux_test.go
File src/pkg/exp/inotify/inotify_linux_test.go (right):

https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux_test.go#newcode112
src/pkg/exp/inotify/inotify_linux_test.go:112: }
defer watcher.Close()

https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux_test.go#newcode123
src/pkg/exp/inotify/inotify_linux_test.go:123: for err := range
watcher.Error {
Does this goroutine exit properly, or does it live on until the end of
the test run ?

https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux_test.go#newcode124
src/pkg/exp/inotify/inotify_linux_test.go:124: t.Fatalf("error received:
%s", err)
you cannot use Fatalf inside a goroutine, use t.Errorf() instead

https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux_test.go#newcode128
src/pkg/exp/inotify/inotify_linux_test.go:128: for event := range
watcher.Event {
Same as above

https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux_test.go#newcode134
src/pkg/exp/inotify/inotify_linux_test.go:134: _, ok :=
watcher.watches[dir]
Is this safe to observe a map that may be mutated by another goroutine ?

https://codereview.appspot.com/6553059/

Search Discussions

Discussion Posts

Previous

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 3 of 3 | next ›
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 23, '12 at 6:42p
activeSep 28, '12 at 2:16a
posts3
users2
websitegolang.org

2 users in discussion

Dave: 2 posts Mbnull Org: 1 post

People

Translate

site design / logo © 2022 Grokbase