[golang-dev] code review 6553059: exp/inotify: cleanup ignored watch (issue 6553059)

[golang-dev] code review 6553059: exp/inotify: cleanup ignored watch (issue 6553059)

	Dave
	Sep 28, 2012 at 2:16 am

On 2012/09/23 12:21:00, mb0 wrote:
Hello mailto:golang-dev@googlegroups.com,
I'd like you to review this change to
https://code.google.com/p/go

Thank you for this fix. I think the test needs a bit more work.

https://codereview.appspot.com/6553059/

Search Discussions

Mbnull Org: Reviewers: golang-dev_googlegroups.com, Message: Hello [email protected] , I'd like you to review this change to https://code.google.com/p/go Description: exp/inotify: cleanup ignored watch inotify sends the IN_IGNORED event whenever a watch was removed. Fixes issue 2483 Please review this at http://codereview.appspot.com/6553059/ Affected files: M src/pkg/exp/inotify/inotify_linux.go M src/pkg/exp/inotify/inotify_linux_test.go Index: src/pkg/exp/inotify/inotify_linux.go

Follow ups

Dave: https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux.go File src/pkg/exp/inotify/inotify_linux.go (right): https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux.go#newcode200 src/pkg/exp/inotify/inotify_linux.go:200: if event.Mask&IN_IGNORED != 0 { ^ gofmt ? https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux_test.go File src/pkg/exp/inotify/inotify_linux_test.go (right)

Discussion Navigation

view	thread \| post
posts	‹ prev \| 2 of 3 \| next ›

Discussion Overview

font	variable	Hotkey: f
user style	avatars	Hotkey: a