[golang-dev] Re: code review 6445105: net: avoid IPv4 header trmming in ReadFrom on IPConn (issue 6445105)

[golang-dev] Re: code review 6445105: net: avoid IPv4 header trmming in ReadFrom on IPConn (issue 6445105)

	Cw
	Sep 18, 2012 at 7:18 pm

I'm wondering if we shouldn't push part of this down into the platform
specific code?

https://codereview.appspot.com/6445105/

Search Discussions

Mikioh Mikioh: differently? unfortunately SOCK_RAW for Windows. http://msdn.microsoft.com/en-us/library/windows/desktop/ms740548(v=vs.85).aspx but fortunately not implemented yet. ;) Russ also pointed out interesting question: src/pkg/net/iprawsock_posix.go:79: if addr.IP.To4() != nil && len(b) > 20 { // discard ipv4 header If sa is an IPv6 sockaddr but it contains an IPv4-mapped address, then addr.IP.To4() will be non-nil here, so you get different behavior for "ip6" using IPv4-mapped addresses vs "ip6"

Follow ups

Discussion Navigation

view	thread \| post
posts	‹ prev \| 8 of 9 \| next ›

Discussion Overview

font	variable	Hotkey: f
user style	avatars	Hotkey: a