[golang-dev] code review 6499102: go/build: reject empty strings in Import (issue 6499102)

[golang-dev] code review 6499102: go/build: reject empty strings in Import (issue 6499102)

	Franciscossouza
	Sep 13, 2012 at 1:49 pm

Hello rsc@golang.org, adg@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

http://codereview.appspot.com/6499102/

Search Discussions

Franciscossouza: of panicking. judgement. Thinking again about it, I realize that it should be an error return. go/build is a package, a library, that provides an exported function with the signature: Import(string, string, ImportMode) (*Package, error). If someone writes a program that can handle errors returned by Import, and continue to run or even give a better error message for the user (like godoc should do), the package function should return an error, not an unrecovered panic. As discussed in go-nuts

Follow ups

Discussion Navigation

view	thread \| post
posts	‹ prev \| 10 of 15 \| next ›

Discussion Overview

font	variable	Hotkey: f
user style	avatars	Hotkey: a