https://codereview.appspot.com/6499102/diff/5003/src/pkg/go/build/build_test.go
File src/pkg/go/build/build_test.go (right):
https://codereview.appspot.com/6499102/diff/5003/src/pkg/go/build/build_test.go#newcode67
src/pkg/go/build/build_test.go:67: t.Fatal("Import should not accept
empty strings.")
On 2012/09/13 14:05:51, rsc wrote:
Use Go syntax to explain what happened.
t.Fatalf(`Import("") returned nil error`)
Done.Use Go syntax to explain what happened.
t.Fatalf(`Import("") returned nil error`)
https://codereview.appspot.com/6499102/diff/5003/src/pkg/go/build/build_test.go#newcode70
src/pkg/go/build/build_test.go:70: t.Fatal("Import should return non-nil
package containing partial information.")
On 2012/09/13 14:05:51, rsc wrote:
t.Fatal(`Import("") returned nil Package`)
Done.t.Fatal(`Import("") returned nil Package`)
https://codereview.appspot.com/6499102/diff/5003/src/pkg/go/build/build_test.go#newcode73
src/pkg/go/build/build_test.go:73: t.Fatalf(`Wrong import path, want "",
got %s.`, p.ImportPath)
On 2012/09/13 14:05:51, rsc wrote:
Please reverse the message to print in the same order you wrote the if
statement.
t.Fatalf("ImportPath=%q, want %q", p.ImportPath, "")
Done.Please reverse the message to print in the same order you wrote the if
statement.
t.Fatalf("ImportPath=%q, want %q", p.ImportPath, "")
https://codereview.appspot.com/6499102/
