dojo/resources/dojo.css was being marked as copyOnly and that's why
there was no importContents for that file. if rawld would do a sanity
check on the patch i've inlined at
http://bugs.dojotoolkit.org/ticket/14108#comment:6 then we can probably
close #14108.
i'm going to look at #14128 next to see if i can find the issue related
to paths not adjusting properly. in order to get this fixed asap, it
wouldn't hurt for others to be looking into the issue at the same time -
ie if you're inclined to look at the problem too, don't stop just
because i'm looking into it.
ben...
On 10/23/2011 9:06 AM, Mike Wilcox wrote:
Sorry this took so long.
I've attached a patched to #14108 that creates a resource from the @imports which allows them to be built into single files.
Still outstanding though is that the background images do not resolve. There is code in the optimizeCss transform to do it, but it always points to the original dojo location, not to the build location, so I don't think it works and I can't figure out how it is intended to work. Also, iirc, the old build tool collected all the images used and put them in a new folder. Relatedly, I haven't been able to get any of my custom code app images to move (I even tried targeting them with a package). I usually have an img folder in my css folder, and it does not copy over; I tried adding "css/img":1 into the copyOnly function in my profile which did not work.
Mike Wilcox
http://clubajax.org
mike at mikewilcox.net
dojo-contributors mailing list
dojo-contributors at mail.dojotoolkit.org
http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
Sorry this took so long.
I've attached a patched to #14108 that creates a resource from the @imports which allows them to be built into single files.
Still outstanding though is that the background images do not resolve. There is code in the optimizeCss transform to do it, but it always points to the original dojo location, not to the build location, so I don't think it works and I can't figure out how it is intended to work. Also, iirc, the old build tool collected all the images used and put them in a new folder. Relatedly, I haven't been able to get any of my custom code app images to move (I even tried targeting them with a package). I usually have an img folder in my css folder, and it does not copy over; I tried adding "css/img":1 into the copyOnly function in my profile which did not work.
Mike Wilcox
http://clubajax.org
mike at mikewilcox.net
On Oct 20, 2011, at 10:34 PM, Rawld Gill wrote:
copied and is available to copy someplace else.
Thanks,
Rawld
_______________________________________________
dojo-contributors mailing list
dojo-contributors at mail.dojotoolkit.org
http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
_______________________________________________On Thursday, October 20, 2011 08:37:25 AM Mike Wilcox wrote:
I can confirm the css build bugs, and talked to Rawld about them last week
(he sounded extraordinarily busy btw). The fix to combine the files is not
too hard (I have a fix, but it may be more of a hack) -
could you post to the ticket. I'll review and commit.
but the fix to
resolve the background-image urls does not look easy, and the mechanism for
gathering the images into a "built" folder is no where to be found
Could you explain more. If the background image is in the source tree, it'sI can confirm the css build bugs, and talked to Rawld about them last week
(he sounded extraordinarily busy btw). The fix to combine the files is not
too hard (I have a fix, but it may be more of a hack) -
could you post to the ticket. I'll review and commit.
but the fix to
resolve the background-image urls does not look easy, and the mechanism for
gathering the images into a "built" folder is no where to be found
copied and is available to copy someplace else.
Thanks,
Rawld
_______________________________________________
dojo-contributors mailing list
dojo-contributors at mail.dojotoolkit.org
http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
dojo-contributors mailing list
dojo-contributors at mail.dojotoolkit.org
http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
