Hi Savva,

Thanks for committing Joda and Java 8 modules. Good stuff! I just did a bit of a cleanup (proper package names in Joda, included Joda module in the assembly, tweaked pom settings for both modules).

One remanining thing is conditional inclusion of cayenne-java8 in Cayenne assemblies. Maybe something you could look at (see CAY-2011 Jira)?


On May 1, 2015, at 9:48 AM, Savva Kolbachev wrote:

Sure. I'll implement it next week.

2015-04-30 20:02 GMT+03:00 John Huss <johnthuss@gmail.com>:
Works for me. Can you make the changes Savva?

On Thu, Apr 30, 2015 at 5:30 AM Savva Kolbachev <s.kolbachev@gmail.com>
I would like to apply John Huss's code from CAY-1626 as separate module.
It's something like I've already made in
https://github.com/apache/cayenne/pull/41 for Java8 time. With one
exception: users need to add another maven dependency.

2015-04-30 9:13 GMT+03:00 Andrus Adamchik <andrus@objectstyle.org>:
Taking this to dev.

I am +1 on the Joda support inclusion in general. Coincidentally we talked
with Savva yesterday about this in the context of another Jira. What we
need to do here though is prevent making Joda a mandatory dependency of
Cayenne, while making bootstrap easy.

Savva suggested making a separate Maven (and DI) module that is
in Cayenne explicitly on startup and that loads all the Joda types at once.
I see the patch has 'registerWithRuntime' per type. A DI module is an
improvement on that (and is similar to how other extensions work - crypto,
osgi, etc.)

On Apr 30, 2015, at 12:50 AM, John Huss (JIRA) <jira@apache.org>

John Huss commented on CAY-1626:

This has been outstanding for a long time. Any objections to merging
after rebasing it on master?
Since Java 8 support is still a ways out and many people (me) have
existing code using joda-time this is still a useful feature.
Add JodaTime DateTime support

Key: CAY-1626
URL: https://issues.apache.org/jira/browse/CAY-1626
Project: Cayenne
Issue Type: Improvement
Components: Database integration
Affects Versions: 3.1M2
Reporter: Marc O'Morain
Attachments: 0001-Add-support-for-joda-time-attributes.patch,
0003-CAY-1626-Add-JodaTime-DateTime-support.patch, DateTimeType.java,

Here is some code that we wrote at Swrve to load/save jodatime
objects with Cayenne

This message was sent by Atlassian JIRA

Search Discussions

Discussion Posts


Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 5 of 5 | next ›
Discussion Overview
groupdev @
postedApr 30, '15 at 6:14a
activeMay 10, '15 at 3:50p



site design / logo © 2022 Grokbase