Search Discussions
-
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" ...
Agl
Dec 22, 2012 at 4:02 pm
Dec 29, 2012 at 12:12 am -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Bradfitz
Dec 26, 2012 at 9:03 pm
Dec 28, 2012 at 5:33 pm -
Pardon my ignorance, but why has this fix not been included in Go 1.0.3?
Tve
Dec 27, 2012 at 6:31 am
Dec 28, 2012 at 3:13 am -
Reviewers: dvyukov, rsc, dfc, minux, remyoudompheng, Message: Hello dvyukov, rsc, dfc, minux, remyoudompheng (cc: <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" ...
0xe2 0x9a 0x9b
Dec 26, 2012 at 12:18 pm
Dec 27, 2012 at 6:36 pm -
Hello <span class="m_body_email_addr" title="7cf1094156d3a2412d2e4a9b81e2578f" adonovan@google.com</span , rsc@golang.org (cc: <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" ...
Gri
Dec 21, 2012 at 2:01 am
Dec 26, 2012 at 8:48 pm -
Reviewers: ken2, Message: Hello ken2 (cc: <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span ), I'd like you to review this change to ...
Rsc
Dec 22, 2012 at 7:54 pm
Dec 25, 2012 at 12:48 am -
Reviewers: rsc, Message: Hello <span class="m_body_email_addr" title="0df663e159099d666c1302f7f355eae8" rsc@golang.org</span (cc: <span class="m_body_email_addr" ...
Mpvl
Dec 19, 2012 at 10:05 am
Dec 24, 2012 at 3:54 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Rsc
Dec 22, 2012 at 4:29 pm
Dec 22, 2012 at 10:31 pm -
Reviewers: ken2, Message: Hello ken2 (cc: <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span ), I'd like you to review this change to ...
Rsc
Dec 22, 2012 at 9:46 pm
Dec 22, 2012 at 9:58 pm -
Hello <span class="m_body_email_addr" title="6ca1b167b392652129ddefeec4c04a93" lvd@gmail.com</span , rsc@golang.org (cc: <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" ...
Remyoudompheng
Dec 22, 2012 at 10:59 am
Dec 22, 2012 at 6:18 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" ...
Remyoudompheng
Dec 22, 2012 at 11:48 am
Dec 22, 2012 at 6:13 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Rsc
Dec 22, 2012 at 3:32 pm
Dec 22, 2012 at 3:43 pm -
Please add a test with an AnyHolder and ",any,omitempty". That should behave like in your test cases but not add the new fields. Please add a test with a []AnyHolder and ",any". It should be able to ...
Rsc
Dec 17, 2012 at 3:04 pm
Dec 22, 2012 at 3:00 pm -
Reviewers: volker.dobler, Message: Hello <span class="m_body_email_addr" title="52eb9d81540fd9e91b82435b194ec9df" dr.volker.dobler@gmail.com</span (cc: <span class="m_body_email_addr" ...
Nigeltao
Dec 21, 2012 at 10:03 am
Dec 22, 2012 at 1:11 am -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Dave
Dec 18, 2012 at 6:04 am
Dec 21, 2012 at 10:09 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" ...
Remyoudompheng
Dec 18, 2012 at 8:41 pm
Dec 21, 2012 at 7:41 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Alex Brainman
Dec 18, 2012 at 3:24 am
Dec 21, 2012 at 5:02 am -
Hi remy, today I encountered this problem, and this CL fixes it. Are you still waiting for other review comments? https://codereview.appspot.com/6920060/
Minux Ma
Dec 20, 2012 at 12:25 pm
Dec 20, 2012 at 10:27 pm -
3
[golang-dev] code review 6973048: testing: only capture stdout when running examples (issue 6973048)
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...Adg
Dec 19, 2012 at 10:46 pm
Dec 20, 2012 at 7:30 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Rsc
Dec 18, 2012 at 9:06 pm
Dec 20, 2012 at 5:23 pm -
Reviewers: iant, Message: Hello <span class="m_body_email_addr" title="10c9912ad968d022471f8319269ecd17" iant@golang.org</span (cc: <span class="m_body_email_addr" ...
Gri
Dec 19, 2012 at 10:08 pm
Dec 19, 2012 at 10:34 pm -
Nice catch, I'm surprised (maybe I should not be) that GCC uses thumb by default. Would a simpler solution be to change cmd/dist to enforce arm mode ? Your solution looks fine, but I cannot comment ...
Dave
Dec 18, 2012 at 11:44 am
Dec 18, 2012 at 9:14 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" ...
Minux Ma
Dec 18, 2012 at 5:32 pm
Dec 18, 2012 at 5:48 pm -
Reviewers: jsing, rsc, Message: Hello <span class="m_body_email_addr" title="5832115b12c06993940873c3dc0eb980" jsing@google.com</span , rsc@golang.org (cc: <span class="m_body_email_addr" ...
Minux Ma
Dec 18, 2012 at 3:04 pm
Dec 18, 2012 at 3:17 pm -
https://codereview.appspot.com/6820120/diff/25002/doc/go1.1.html File doc/go1.1.html (right): https://codereview.appspot.com/6820120/diff/25002/doc/go1.1.html#newcode90 doc/go1.1.html:90: On Darwin, ...
Minux Ma
Dec 17, 2012 at 2:39 pm
Dec 18, 2012 at 2:57 pm -
LGTM https://codereview.appspot.com/6936058/
Rsc
Dec 17, 2012 at 2:51 pm
Dec 17, 2012 at 8:59 pm -
https://codereview.appspot.com/6949058/diff/6001/src/pkg/time/time_test.go File src/pkg/time/time_test.go (right) ...
Rsc
Dec 17, 2012 at 12:43 am
Dec 17, 2012 at 8:54 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" ...
Diogin
Dec 17, 2012 at 4:29 am
Dec 17, 2012 at 4:12 pm -
https://codereview.appspot.com/6935062/diff/4001/src/pkg/runtime/sys_plan9_386.s File src/pkg/runtime/sys_plan9_386.s (right) ...
Rsc
Dec 17, 2012 at 1:14 am
Dec 17, 2012 at 4:07 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Adg
Dec 17, 2012 at 1:26 am
Dec 17, 2012 at 1:58 am -
Reviewers: remyoudompheng, Message: Hello <span class="m_body_email_addr" title="ddd35f5f40ad7071c650901fc01e0651" remyoudompheng@gmail.com</span (cc: <span class="m_body_email_addr" ...
Dave
Dec 15, 2012 at 12:41 pm
Dec 15, 2012 at 7:02 pm -
https://codereview.appspot.com/6900055/diff/18001/oauth/oauth.go File oauth/oauth.go (right): https://codereview.appspot.com/6900055/diff/18001/oauth/oauth.go#newcode296 oauth/oauth.go:296: content ...
Nightlyone
Dec 15, 2012 at 2:36 am
Dec 15, 2012 at 8:21 am -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" ...
Mikioh Mikioh
Dec 15, 2012 at 4:22 am
Dec 15, 2012 at 5:19 am -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
James Chalfant
Dec 13, 2012 at 1:28 am
Dec 14, 2012 at 8:19 am -
LGTM. https://codereview.appspot.com/6944048/
Dave
Dec 14, 2012 at 7:32 am
Dec 14, 2012 at 7:53 am -
PTAL genzip.sh generates gotour.zip containing a directory structure that allows running "go run run.go" in the decompressed folder and everything works. I think that this is pretty much what we were ...
Campoy
Dec 13, 2012 at 2:47 am
Dec 13, 2012 at 8:56 pm -
Haven't thought through this is detail yet, but here some prelim. feedback. Please pay attention particularly to the re-use of the underlying slices by using the appropriate set functions. We have ...
Gri
Dec 13, 2012 at 1:52 am
Dec 13, 2012 at 2:42 pm -
LGTM thanks :) https://codereview.appspot.com/6929059/diff/1/static/playground.js File static/playground.js (right): https://codereview.appspot.com/6929059/diff/1/static/playground.js#newcode89 ...
Bradfitz
Dec 12, 2012 at 11:09 pm
Dec 13, 2012 at 2:46 am -
Just one documentation glitch. https://codereview.appspot.com/6920051/diff/5001/src/cmd/gc/go.y File src/cmd/gc/go.y (right) ...
Franciscossouza
Dec 12, 2012 at 2:19 am
Dec 12, 2012 at 3:44 pm -
Hi, not sure if this is the right mailing list for this post but I just ran into a Virus warning when I build go on Windows 7 64-bit with MinGW. go version devel +2888e5323790 Tue Dec 11 13:36:55 ...
__Mario__
Dec 11, 2012 at 9:53 pm
Dec 12, 2012 at 10:59 am -
LGTM https://codereview.appspot.com/6856121/
Dvyukov
Dec 12, 2012 at 6:10 am
Dec 12, 2012 at 10:47 am -
Ping https://codereview.appspot.com/6842045/
Dave
Dec 11, 2012 at 11:52 pm
Dec 12, 2012 at 8:25 am -
https://codereview.appspot.com/6868090/diff/20001/idna/idna.go File idna/idna.go (right): https://codereview.appspot.com/6868090/diff/20001/idna/idna.go#newcode56 idna/idna.go:56: for _, r := range s ...
Nigeltao
Dec 12, 2012 at 12:08 am
Dec 12, 2012 at 6:33 am -
3
[golang-dev] code review 6933049: go.talks/pkg/present: Fixing image size handling. (issue 6933049)
Reviewers: adg, Message: Hello <span class="m_body_email_addr" title="9372cecb2e4335ef6f1172cda806b50b" adg@golang.org</span (cc: <span class="m_body_email_addr" ...Campoy
Dec 12, 2012 at 3:24 am
Dec 12, 2012 at 3:24 am -
Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" ...
Chris Cahoon
Dec 11, 2012 at 8:09 pm
Dec 11, 2012 at 8:40 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Rsc
Dec 11, 2012 at 5:36 pm
Dec 11, 2012 at 6:44 pm -
Reviewers: rsc, Message: Hello <span class="m_body_email_addr" title="0df663e159099d666c1302f7f355eae8" rsc@golang.org</span (cc: <span class="m_body_email_addr" ...
Gri
Dec 11, 2012 at 6:02 am
Dec 11, 2012 at 6:19 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Rsc
Dec 11, 2012 at 5:00 pm
Dec 11, 2012 at 5:19 pm -
https://codereview.appspot.com/6900055/diff/5001/oauth/oauth.go File oauth/oauth.go (right): https://codereview.appspot.com/6900055/diff/5001/oauth/oauth.go#newcode254 oauth/oauth.go:254 ...
Adg
Dec 11, 2012 at 6:32 am
Dec 11, 2012 at 2:55 pm -
Is it true that there are NO POSSIBLE invalid inputs for punycode.Encode? We already screwed up xml.Escape twice (two different errors we'd like to return). Russ
Russ Cox
Dec 10, 2012 at 3:38 am
Dec 10, 2012 at 11:04 pm
Group Overview
| group | golang-dev |
| categories | go |
| discussions | 633 |
| posts | 2,238 |
| users | 106 |
| website | golang.org |
106 users for December 2012
Archives
- June 2016 (161)
- May 2016 (149)
- April 2016 (310)
- March 2016 (570)
- February 2016 (331)
- January 2016 (345)
- December 2015 (143)
- November 2015 (299)
- October 2015 (352)
- September 2015 (328)
- August 2015 (339)
- July 2015 (249)
- June 2015 (346)
- May 2015 (485)
- April 2015 (415)
- March 2015 (675)
- February 2015 (383)
- January 2015 (445)
- December 2014 (704)
- November 2014 (363)
- October 2014 (387)
- September 2014 (499)
- August 2014 (711)
- July 2014 (542)
- June 2014 (109)
- May 2014 (181)
- April 2014 (337)
- March 2014 (512)
- February 2014 (554)
- January 2014 (554)
- December 2013 (2,655)
- November 2013 (1,704)
- October 2013 (2,235)
- September 2013 (2,693)
- August 2013 (4,409)
- July 2013 (3,287)
- June 2013 (3,126)
- May 2013 (2,893)
- April 2013 (2,209)
- March 2013 (4,142)
- February 2013 (3,737)
- January 2013 (2,959)
- December 2012 (2,238)
- November 2012 (2,578)
- October 2012 (2,535)
- September 2012 (2,763)
- August 2012 (99)