Search Discussions
-
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" ...
Remyoudompheng
Dec 3, 2012 at 4:53 pm
Dec 6, 2012 at 5:58 am -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Bradfitz
Dec 19, 2012 at 2:33 am
Jan 7, 2013 at 7:34 pm -
Change cbf3546de9ae broke the netbsd-386-minux build: http://build.golang.org/log/c650e4de7f289eafe04d8279ebba1195cc4a668f cmd/ld: fix valgrind warning in strnput Fixes issue 4592. Thanks to minux ...
Builder
Dec 28, 2012 at 4:43 am
Dec 30, 2012 at 11:27 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Dave
Dec 29, 2012 at 9:29 am
Dec 30, 2012 at 8:54 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Elias Naur
Dec 24, 2012 at 11:59 pm
Dec 29, 2012 at 12:21 am -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Dvyukov
Dec 24, 2012 at 5:12 pm
Dec 28, 2012 at 11:36 am -
PTAL https://codereview.appspot.com/6931049/
Alakriti
Dec 19, 2012 at 3:20 pm
Dec 22, 2012 at 4:15 pm -
Hello <span class="m_body_email_addr" title="4353eb061a584ea6af6521ba820f3809" dsallings@gmail.com</span , kamil.kisiel@gmail.com, <span class="m_body_email_addr" ...
Dave
Dec 19, 2012 at 11:05 am
Dec 21, 2012 at 7:21 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Alex Brainman
Dec 20, 2012 at 5:19 am
Dec 21, 2012 at 5:39 am -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Adg
Dec 19, 2012 at 11:22 pm
Dec 20, 2012 at 8:06 pm -
Though strange, I just determined that this change is responsible for a test failure of Go on Darwin/ARM. Without this change, fixedbugs/bug348.go could get this traceback (I just printed out pc, ...
Minux Ma
Dec 18, 2012 at 11:32 pm
Dec 19, 2012 at 1:18 am -
PTAL Now genzip.sh generates a zip containing the executable gotour binary. If GOPATH is not set it will be set to the current directory by the gotour ...
Campoy
Dec 14, 2012 at 12:17 am
Dec 17, 2012 at 11:04 pm -
Reviewers: rsc, Message: Hello <span class="m_body_email_addr" title="0df663e159099d666c1302f7f355eae8" rsc@golang.org</span (cc: <span class="m_body_email_addr" ...
Gri
Dec 17, 2012 at 9:06 pm
Dec 17, 2012 at 10:32 pm -
Thank you for your comments. PTAL. https://codereview.appspot.com/6939056/diff/2001/src/pkg/sync/atomic/asm_linux_arm.s File src/pkg/sync/atomic/asm_linux_arm.s (right) ...
Dave
Dec 16, 2012 at 1:23 am
Dec 16, 2012 at 2:23 am -
PTAL. I've modified the description as requested. Thanks, Erik https://codereview.appspot.com/6931047/
Alakriti
Dec 12, 2012 at 2:12 am
Dec 12, 2012 at 9:29 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Alakriti
Dec 12, 2012 at 2:52 am
Dec 12, 2012 at 7:48 pm -
Reviewers: agl1, dfc, Message: Hello <span class="m_body_email_addr" title="bd35087f520eed74aa17a1c580118e26" agl@golang.org</span , dave@cheney.net (cc: <span class="m_body_email_addr" ...
Jmpittman
Dec 11, 2012 at 1:12 am
Dec 11, 2012 at 9:52 pm -
This looks like a pretty straight forward change. I notice that the test for various error messages are commented out int regexp/all_test.go. It would be nice to investigate reactivating them, either ...
Dave
Dec 11, 2012 at 12:58 pm
Dec 11, 2012 at 5:25 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" ...
Remyoudompheng
Dec 9, 2012 at 10:17 am
Dec 9, 2012 at 6:27 pm -
Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , <span class="m_body_email_addr" title="90f92f72288ead247afce50780c749cc" ...
Jeff Allen
Dec 6, 2012 at 9:40 am
Dec 7, 2012 at 3:29 pm -
Reviewers: rsc, iant, r, ken2, Message: Hello <span class="m_body_email_addr" title="0df663e159099d666c1302f7f355eae8" rsc@golang.org</span , iant@golang.org, <span class="m_body_email_addr" ...
Gri
Dec 5, 2012 at 11:05 pm
Dec 6, 2012 at 11:11 pm -
Hello <span class="m_body_email_addr" title="0df663e159099d666c1302f7f355eae8" rsc@golang.org</span , iant@golang.org (cc: <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" ...
Mikioh Mikioh
Dec 1, 2012 at 7:13 am
Dec 6, 2012 at 6:27 am -
https://codereview.appspot.com/6869054/diff/1003/src/pkg/net/net.go File src/pkg/net/net.go (right): https://codereview.appspot.com/6869054/diff/1003/src/pkg/net/net.go#newcode203 ...
Rsc
Dec 4, 2012 at 3:22 pm
Dec 6, 2012 at 4:31 am -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Bradfitz
Dec 3, 2012 at 9:59 pm
Dec 6, 2012 at 3:25 am -
I went through the open Go 1.1 issues and marked each with a size S, M, L, XL according to how much work I expect it to be. I also marked issues that are "ready to go" with a label Suggested. This ...
Russ Cox
Dec 10, 2012 at 6:28 am
Jan 21, 2013 at 1:26 am -
For the use of stdcall functions in cgo, it seems the only part of the Go toolchain that doesn't support them yet is cmd/ld. But, it does seem to handle them mostly ok. Currently when you try to call ...
James4k
Dec 28, 2012 at 7:38 am
Jan 2, 2013 at 11:57 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" ...
Minux Ma
Dec 30, 2012 at 8:02 pm
Jan 2, 2013 at 9:16 pm -
https://codereview.appspot.com/6945065/diff/4001/src/pkg/encoding/json/encode.go File src/pkg/encoding/json/encode.go (right) ...
Rsc
Dec 17, 2012 at 12:37 am
Dec 26, 2012 at 12:06 pm -
Change 1159634f1624 broke the openbsd-amd64 build: http://build.golang.org/log/299de1f0ffefb5ed9925a8a3289562b27ac669ee cmd/gc: fix eval order in select Ordinary variable load was assumed to be not ...
Builder
Dec 22, 2012 at 10:33 pm
Dec 23, 2012 at 1:27 am -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Brtsz
Dec 21, 2012 at 2:30 pm
Dec 22, 2012 at 4:43 pm -
Reviewers: ken2, Message: Hello ken2 (cc: <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span ), I'd like you to review this change to ...
Rsc
Dec 17, 2012 at 7:32 pm
Dec 22, 2012 at 3:16 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" ...
Remyoudompheng
Dec 20, 2012 at 11:49 pm
Dec 21, 2012 at 10:46 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Dsymonds
Dec 21, 2012 at 12:26 am
Dec 21, 2012 at 2:48 am -
do you want to fix various docs in this CL or in a subsequent CL? https://codereview.appspot.com/6853059/
Minux Ma
Dec 18, 2012 at 3:06 pm
Dec 20, 2012 at 2:43 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Adg
Dec 18, 2012 at 10:28 pm
Dec 18, 2012 at 11:14 pm -
https://codereview.appspot.com/6948059/diff/12001/ssh/client.go File ssh/client.go (right): https://codereview.appspot.com/6948059/diff/12001/ssh/client.go#newcode313 ssh/client.go:313: if ...
Agl
Dec 17, 2012 at 3:08 pm
Dec 18, 2012 at 4:37 pm -
I don't fully understand the motivation here. We seem to be testing package net okay right now. Perhaps this should start out as go.net/nettest? ...
Rsc
Dec 17, 2012 at 12:35 am
Dec 18, 2012 at 12:36 am -
PTAL https://codereview.appspot.com/6946057/
Rickarnoldjr
Dec 17, 2012 at 1:16 am
Dec 17, 2012 at 3:37 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span , I'd like you to review this change ...
Adg
Dec 17, 2012 at 12:20 am
Dec 17, 2012 at 3:30 am -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" ...
Minux Ma
Dec 15, 2012 at 1:16 pm
Dec 16, 2012 at 11:13 pm -
Hi, On this page: http://golang.org/doc/effective_go.html I can not unmderstand the following sentence: "Line comments are the norm; block comments appear mostly as package comments and are also ...
Kosztka Imre Dávid
Dec 14, 2012 at 6:44 am
Dec 14, 2012 at 4:29 pm -
Reviewers: dfc, agl1, Message: Hello <span class="m_body_email_addr" title="fda08117336cfde6562315df04b976e8" dave@cheney.net</span , agl@golang.org (cc: <span class="m_body_email_addr" ...
Jmpittman
Dec 13, 2012 at 11:19 pm
Dec 13, 2012 at 11:34 pm -
there is another "float" in /test/fixedbugs/bug085.go: // universe scope (contains predeclared identifiers int, float, int32, len, etc.) ...
Minux Ma
Dec 13, 2012 at 11:00 pm
Dec 13, 2012 at 11:20 pm -
LGTM, very nice, thank you. A few minor comments if you feel like addressing them in this CL. https://codereview.appspot.com/6873060/diff/12001/ssh/certs.go File ssh/certs.go (right) ...
Dave
Dec 13, 2012 at 11:16 am
Dec 13, 2012 at 10:04 pm -
5
[golang-dev] code review 6946044: test/nil.go: delete on nil maps no longer panics (issue 6946044)
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" ...Minux Ma
Dec 13, 2012 at 6:13 pm
Dec 13, 2012 at 6:59 pm -
Can we do something about this? a) turn it off. b) make it stop emailing (introduce a 2nd-class-port status that builds but doesn't email?) c) get it decent hardware d) make tests reliable e) fix ...
Brad Fitzpatrick
Dec 12, 2012 at 6:36 pm
Dec 13, 2012 at 5:51 pm -
suggestions. Here are some quick results from a dual core pandaboard, taking the best of a few runs to eliminate disk io as much as possible (hopefully all the source was cached, and $TMP is a tmpfs) ...
Dave
Dec 11, 2012 at 1:56 am
Dec 11, 2012 at 10:37 pm -
Reviewers: golang-dev_googlegroups.com, Message: Hello <span class="m_body_email_addr" title="c3ecb5e27faf47760cdc327c77b2bcea" golang-dev@googlegroups.com</span (cc: <span class="m_body_email_addr" ...
Remyoudompheng
Dec 11, 2012 at 7:33 am
Dec 11, 2012 at 10:16 pm -
https://codereview.appspot.com/6856121/diff/16001/src/pkg/runtime/mgc0.c File src/pkg/runtime/mgc0.c (right): https://codereview.appspot.com/6856121/diff/16001/src/pkg/runtime/mgc0.c#newcode210 ...
Dvyukov
Dec 10, 2012 at 8:19 am
Dec 11, 2012 at 5:27 pm -
We changed this a while back to make the examples more discoverable. This restores the earlier behavior. Hm. https://codereview.appspot.com/6868071/
Adg
Dec 10, 2012 at 4:21 am
Dec 11, 2012 at 1:20 am
Group Overview
| group | golang-dev |
| categories | go |
| discussions | 633 |
| posts | 2,238 |
| users | 106 |
| website | golang.org |
106 users for December 2012
Archives
- June 2016 (161)
- May 2016 (149)
- April 2016 (310)
- March 2016 (570)
- February 2016 (331)
- January 2016 (345)
- December 2015 (143)
- November 2015 (299)
- October 2015 (352)
- September 2015 (328)
- August 2015 (339)
- July 2015 (249)
- June 2015 (346)
- May 2015 (485)
- April 2015 (415)
- March 2015 (675)
- February 2015 (383)
- January 2015 (445)
- December 2014 (704)
- November 2014 (363)
- October 2014 (387)
- September 2014 (499)
- August 2014 (711)
- July 2014 (542)
- June 2014 (109)
- May 2014 (181)
- April 2014 (337)
- March 2014 (512)
- February 2014 (554)
- January 2014 (554)
- December 2013 (2,655)
- November 2013 (1,704)
- October 2013 (2,235)
- September 2013 (2,693)
- August 2013 (4,409)
- July 2013 (3,287)
- June 2013 (3,126)
- May 2013 (2,893)
- April 2013 (2,209)
- March 2013 (4,142)
- February 2013 (3,737)
- January 2013 (2,959)
- December 2012 (2,238)
- November 2012 (2,578)
- October 2012 (2,535)
- September 2012 (2,763)
- August 2012 (99)