FAQ
In perl.git, the branch blead has been updated

<http://perl5.git.perl.org/perl.git/commitdiff/fbe0543bcbaefe00657a5aa89d684a59c352cb84?hp=18d04e70ad3150934855463233bb7dc953f33a23>

- Log -----------------------------------------------------------------
commit fbe0543bcbaefe00657a5aa89d684a59c352cb84
Author: Father Chrysostomos <sprout@cpan.org>
Date: Sun May 29 15:48:24 2016 -0700

     op.c:S_my_kid: Remove obsolete comment

     /* XXX does this let anything illegal in? */

     The commit that added that comment indeed allowed ‘our $$x’ and even
     â€˜my $$x’, so it was a problem at the time. It was this commit:

     commit 77ca0c92d2c0e47301d906d355d9ab3afb6f6bcb
     Author: Larry Wall <larry@wall.org>
     Date: Fri Sep 24 14:59:37 1999 -0700

         Re: [PATCH 5.005_61] "our" declarations

     This commit fixed the problem:

     commit b6512f489e761186d508cf0b8b7705805cfefc52
     Author: Mark-Jason Dominus <mjd@plover.com>
     Date: Mon Dec 24 13:14:48 2001 -0500

         PATCH: Restore "Can't declare scalar dereference in my" error

     so the comment is no longer relevant.
-----------------------------------------------------------------------

Summary of changes:
  op.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/op.c b/op.c
index 619c6e3..90258f2 100644
--- a/op.c
+++ b/op.c
@@ -3668,7 +3668,7 @@ S_my_kid(pTHX_ OP *o, OP *attrs, OP **imopsp)
   return o;
      } else if (type == OP_RV2SV || /* "our" declaration */
          type == OP_RV2AV ||
- type == OP_RV2HV) { /* XXX does this let anything illegal in? */
+ type == OP_RV2HV) {
   if (cUNOPo->op_first->op_type != OP_GV) { /* MJD 20011224 */
       S_cant_declare(aTHX_ o);
   } else if (attrs) {

--
Perl5 Master Repository

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupperl5-changes @
categoriesperl
postedMay 30, '16 at 3:14a
activeMay 30, '16 at 3:14a
posts1
users1
websiteperl.org

1 user in discussion

Father Chrysostomos: 1 post

People

Translate

site design / logo © 2018 Grokbase