Grokbase
x

Nicholas Clark (n...@ccl4.org)

Profile | Posts (3778)

User Information

Display Name:Nicholas Clark
Partial Email Address:n...@ccl4.org
Posts:
3778 total
31 in PAR
3748 in Perl 5 Porters

5 Most Recent

All Posts
1) Nicholas Clark Re: Why is there no deprecation cycle for "forbid keywords as labels"?
| +1 vote
Sorry, I was distracted by the versions with a sub AUTOLOAD too, and missed that. Nicholas Clark
Perl 5 Porters
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
On Sat, Feb 20, 2010 at 03:03:19AM -0800, Jan Dubois wrote:
> On Sat, 20 Feb 2010, Nicholas Clark wrote:
> >
> > Aren't all the current cases that the change forbids, cases where the goto
> > will fail at run time? ie the current bug already prevents the code from
> > running.
> >
> > (My argument falls apart completely if it can be demonstrated that there is
> > working-as-programmer-intended code that stops working with this change in)
>
> >From my original message:
>
> C:\>c:\perl5.10.1\bin\perl -wle "AUTOLOAD: print ++$_; goto AUTOLOAD if $_ < 3"
>   1
>   2
>   3
>
> This code no longer works with blead:
>
> C:\>c:\blead\bin\perl -wle "AUTOLOAD: print ++$_; goto AUTOLOAD if $_ < 3"
> Can't use keyword 'AUTOLOAD' as a label at -e line 1.

Sorry, I was distracted by the versions with a sub AUTOLOAD too, and missed
that.

Nicholas Clark
2) Nicholas Clark Re: Why is there no deprecation cycle for "forbid keywords as labels"?
| +1 vote
I agree with that assessment. However: Aren't all the current cases that the change forbids, cases...
Perl 5 Porters
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
On Sat, Feb 20, 2010 at 02:16:36AM -0800, Jan Dubois wrote:
> Sorry, the bug is clearly that "goto AUTOLOAD" calls AUTOLOAD() and seems to be an artifact of the implementation rather than a
> design feature. So the correct fix would be to stop it from calling the sub instead of forbidding some arbitrary function names from
> being used as labels. Or is there any reason why the current behavior is actually reasonable and desirable?
>
>  
>
> Even if you would disagree with that assessment, there is still no justification to break the current code without a deprecation
> cycle.

I agree with that assessment. However:


> From: [email protected: ik...@gmail.com] On Behalf Of Eric Brine
> Sent: Friday, February 19, 2010 5:30 PM
> To: Jan Dubois
> Cc: Perl5 Porters
> Subject: Re: Why is there no deprecation cycle for "forbid keywords as labels"?

> It does fix a bug and AUTOLOAD is special. Both are demonstrated by the following:
>
> >perl -e"sub AUTOLOAD { 1 } goto AUTOLOAD; AUTOLOAD:1"
> Can't find label 1 at -e line 1.
>
> >perl -e"sub autoload { 1 } goto autoload; autoload:1"
>
> >

Aren't all the current cases that the change forbids, cases where the goto
will fail at run time? ie the current bug already prevents the code from
running.

(My argument falls apart completely if it can be demonstrated that there is
working-as-programmer-intended code that stops working with this change in)

Nicholas Clark
3) Nicholas Clark Perl 5 Commit Summary
| +1 vote
Perl 5 commit summary, activity since Wednesday Current branch blead 28 commits. 8 unique authors....
Perl 5 Porters
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
Perl 5 commit summary, activity since Wednesday

Current branch blead
28 commits.  8 unique authors.  5 unique committers.
35 files changed, 792 insertions(+), 437 deletions(-)
Thanks, applied:  Rafael Garcia-Suarez (2) Jesse Vincent (2) Steve Hay (2)
Snapshot: http://perl5.git.perl.org/perl.git/snapshot/c500e02848ab1c4e.tar.gz

  Regen headers after previous patches
  Steve Hay                   2 files changed, 5 insertions(+), 0 deletions(-)
http://perl5.git.perl.org/perl.git/commit/c500e02848ab1c4e

  Add X flag to embed.fnc entries.
  Karl Williamson             1 file changed, 11 insertions(+), 11 deletions(-
http://perl5.git.perl.org/perl.git/commit/0801f9a3ebbd8db1

  Move some fncs from Public to extensions visible
  Karl Williamson             1 file changed, 10 insertions(+), 10 deletions(-
http://perl5.git.perl.org/perl.git/commit/5556d2fa424723dd

  More updates to perl5115delta.pod
  Steve Hay                   1 file changed, 10 insertions(+), 0 deletions(-)
http://perl5.git.perl.org/perl.git/commit/e6a8543aedf911a5

  Avoid returning an undefined SV*
  Rafael Garcia-Suarez        1 file changed, 2 insertions(+), 1 deletion(-)
http://perl5.git.perl.org/perl.git/commit/f5a573297aad004c

  Regen headers after previous patches
  Rafael Garcia-Suarez        2 files changed, 13 insertions(+), 8 deletions(-
http://perl5.git.perl.org/perl.git/commit/70a6e658a75720da

  Make a missing right brace on \N{ fatal
  Karl Williamson             2 files changed, 24 insertions(+), 39 deletions(
http://perl5.git.perl.org/perl.git/commit/0a96133fa53fe1b2

  PATCH: [perl #56444] delayed interpolation of \N{...}
  Karl Williamson             10 files changed, 659 insertions(+), 374 deletio
http://perl5.git.perl.org/perl.git/commit/ff3f963aa0f95ea5

  Update perldelta for 5.12 to warn vendors about deprecate.pm
  Jesse Vincent               1 file changed, 11 insertions(+), 0 deletions(-)
http://perl5.git.perl.org/perl.git/commit/8df7d2a3b2f29aff

  rt #72866 - add magic to arrayrefs assigned to *Foo::ISA
  Tony Cook                   2 files changed, 27 insertions(+), 5 deletions(-
http://perl5.git.perl.org/perl.git/commit/d851b1227a19f97a

  Avoid a panic from the UTF-8 length cache if the length overflows 32 bits.
  Nicholas Clark              1 file changed, 4 insertions(+), 0 deletions(-)
http://perl5.git.perl.org/perl.git/commit/566a4373528224e6

  In Perl_reg_temp_copy(), ensure SvMAGIC() is NULL in the new REGEXP.
  Nicholas Clark              1 file changed, 1 insertion(+), 0 deletions(-)
http://perl5.git.perl.org/perl.git/commit/703c388dcb4a811f

  Keep perl5115delta.pod up to date
  Steve Hay                   1 file changed, 1 insertion(+), 1 deletion(-)
http://perl5.git.perl.org/perl.git/commit/4d5229574fc575d9

  Upgrade podlators from 2.3.0 to 2.3.1
  Steve Hay                   4 files changed, 4 insertions(+), 4 deletions(-)
http://perl5.git.perl.org/perl.git/commit/a551d937fd3e2ba4

  Update perl5115delta.pod with today's changes
  Steve Hay                   1 file changed, 8 insertions(+), 1 deletion(-)
http://perl5.git.perl.org/perl.git/commit/a4cc96117b620fea

  Upgrade CPAN from 1.94_55 to 1.94_56
  Steve Hay                   9 files changed, 17 insertions(+), 9 deletions(-
http://perl5.git.perl.org/perl.git/commit/99ad6f11b89e2dcc

  Merge branch 'pod-perlrepository' of git://github.com/avar/perl into blead
  Jesse Vincent               2 parents
http://perl5.git.perl.org/perl.git/commit/f54260a347c70d42

  Make the new Socket implementation of inet_pton consistent with the existing
  Jesse Vincent               2 files changed, 3 insertions(+), 2 deletions(-)
http://perl5.git.perl.org/perl.git/commit/3aca805b785501fb

  Documentation fix in perldoc's usage statement.  (-A -> -v)
  Offer Kaye                  1 file changed, 2 insertions(+), 2 deletions(-)
http://perl5.git.perl.org/perl.git/commit/90fdd774eb4f7910

  Change my email address from work to home
  Steve Hay                   3 files changed, 4 insertions(+), 3 deletions(-)
http://perl5.git.perl.org/perl.git/commit/03c4920e421b61a2

  Keep perl5115delta.pod up to date
  Steve Hay                   1 file changed, 8 insertions(+), 4 deletions(-)
http://perl5.git.perl.org/perl.git/commit/ca127710352774fe

  Mention why it's a good idea to use topic branches for everything
Ævar Arnfjörð Bjarmason 1 file changed, 8 insertions(+), 0 deletions(-)
http://perl5.git.perl.org/perl.git/commit/0c24b290ae02b2ab

  Adjusted the git config user.name/user.email example for what 99% of users w
Ævar Arnfjörð Bjarmason 1 file changed, 9 insertions(+), 3 deletions(-)
http://perl5.git.perl.org/perl.git/commit/9d77ce3f21b279b4

  Prefix commands universally with "%". Most of the POD used that convention b
Ævar Arnfjörð Bjarmason 1 file changed, 6 insertions(+), 6 deletions(-)
http://perl5.git.perl.org/perl.git/commit/e0b2b458eee3edd8

Don't recommend that people manually fiddle with their F<.git/config>, inste
Ævar Arnfjörð Bjarmason 1 file changed, 4 insertions(+), 9 deletions(-)
http://perl5.git.perl.org/perl.git/commit/11ed6e28a169ef2a

  Fix another place where I typoed book's name
  Jesse Vincent               1 file changed, 1 insertion(+), 1 deletion(-)
http://perl5.git.perl.org/perl.git/commit/6dde2df7567ece5b

  Doc fix. Thanks to Bram.
  Jesse Vincent               1 file changed, 1 insertion(+), 1 deletion(-)
http://perl5.git.perl.org/perl.git/commit/77d4bad069ecbeed

  Note that checking out from git via http:// is at least 4x slower than git:/
  Ã†var Arnfjörð Bjarmason     1 file changed, 1 insertion(+), 1 deletion(-)
http://perl5.git.perl.org/perl.git/commit/cf5e7595dae7f3a6
4) Nicholas Clark Re: Updated PATCH: [perl #56444] \N{...}
| +1 vote
Rafael pointed out on IRC that I'm confusing 'A' and 'P'. It's not 'A'.* The confusion arose...
Perl 5 Porters
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
On Fri, Feb 19, 2010 at 10:35:19AM +0000, Nicholas Clark wrote:
> On Fri, Feb 19, 2010 at 11:30:04AM +0100, Rafael Garcia-Suarez wrote:
>
> > The fix was trivial, see
> > http://perl5.git.perl.org/perl.git/commitdiff/f5a573297aad004c6761b844d65a3e6d8402cd50
> >
> > Thanks, both patches applied to bleadperl. Just in time for the next
> > dev release!
>
> Does regcurly really need to be part of the public API?
> ie instead of 'P', can it be 'p', non-static, but private.

Rafael pointed out on IRC that I'm confusing 'A' and 'P'.
It's not 'A'.*

The confusion arose because I mis-interpreted
"make public the function regcurly()"

Nicholas Clark
5) Nicholas Clark Re: Updated PATCH: [perl #56444] \N{...}
| +1 vote
Does regcurly really need to be part of the public API? ie instead of 'P', can it be 'p',...
Perl 5 Porters
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
On Fri, Feb 19, 2010 at 11:30:04AM +0100, Rafael Garcia-Suarez wrote:

> The fix was trivial, see
> http://perl5.git.perl.org/perl.git/commitdiff/f5a573297aad004c6761b844d65a3e6d8402cd50
>
> Thanks, both patches applied to bleadperl. Just in time for the next
> dev release!

Does regcurly really need to be part of the public API?
ie instead of 'P', can it be 'p', non-static, but private.

Nicholas Clark

spacer
Profile | Posts (3778)
Home > People > Nicholas Clark