Grokbase
Topics Posts Groups | in
x
[ help ]

Rafael Garcia-Suarez (rgarcias...@gmail.com)

Profile | Posts (942)

User Information

Display Name:Rafael Garcia-Suarez
Partial Email Address:rgarcias...@gmail.com
Posts:
942 total
1 in Catalyst Framework
1 in PAR
940 in Perl 5 Porters

5 Most Recent

All Posts
1) Rafael Garcia-Suarez Re: t/op/regexp_unicode_prop_thr.t marked as binary in APC
| +1 vote
2008/11/19 Nicholas Clark <nick@ccl4.org>: I don't think that reason alone was sufficient to go...
Perl 5 Porters
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
2008/11/19 Nicholas Clark <nick@ccl4.org>:
> On Wed, Nov 19, 2008 at 10:29:32AM +0100, Rafael Garcia-Suarez wrote:
>> 2008/11/19 Andreas J. Koenig <andreas.koenig.7os6VVqR@franz.ak.mind.de>:
>
>> > Rafael, do you still know how such a file can be decontaminated once
>> > it has been added to Perforce?
>>
>> I think that the trick was to add a packed version of the
>> "contaminated" file in the source code of the APC tools.
>
> In this case, I believe that I already fixed the metadata within perforce.
>
>> Well, with the forthcoming git move, that kind of problem should
>> disappear. We should probably get rid of all .packed files and add a
>> .gitattributes files at the root to record which files are binary.
>> (Versioned metadata. Yay)
>
> I'm not convinced that that's reason alone.
>
> Perforce, also, is quite capable of holding binary files, yet we've chosen
> deliberately not to have any. I'm not sure of *all* of the reasons why, but
> one of them is it useful having the mailed diffs being canonical, rather than
> partial, because one can verify all the commits.

I don't think that reason alone was sufficient to go through the
hassle of setting up uupacktool.pl. Wasn't there a packaging reason as
well? Or maybe it was just for people reconstructing a bleadperl (or a
repository holding bleadperl) purely from the APC patches?

Basically, what will break if we unpack the binary files ?
2) Rafael Garcia-Suarez Re: t/op/regexp_unicode_prop_thr.t marked as binary in APC
| +1 vote
2008/11/19 Andreas J. Koenig <andreas.koenig.7os6VVqR@franz.ak.mind.de>: I think that the trick was...
Perl 5 Porters
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
2008/11/19 Andreas J. Koenig <andreas.koenig.7os6VVqR@franz.ak.mind.de>:
> The APC had always troubles with files containing bytes with the high
> bit set. Consequently t/op/regexp_unicode_prop_thr.t is now missing in
> the APC. Porting/patching.pod talks about this:
>
>  =item Binary Files
>
> Since the patch(1) utility cannot deal with binary files, it's important
> that you either avoid the use of binary files in your patch, generate the
> files dynamically, or that you encode any binary files using the
>  F<uupacktool.pl> utility.
>
> Assuming you needed to include a gzip-encoded file for a module's test
> suite, you might do this as follows using the F<uupacktool.pl> utility:
>
> $ perl uupacktool.pl -v -p -D lib/Some/Module/t/src/t.gz
> Writing lib/Some/Module/t/src/t.gz into lib/Some/Module/t/src/t.gz.packed
>
> This will replace the C<t.gz> file with an encoded counterpart. During
> C<make test>, before any tests are run, perl's Makefile will restore all
> the C<.packed> files mentioned in the MANIFEST to their original name.
> This means that the test suite does not need to be aware of this packing
>  scheme and will not need to be altered.
>
> Rafael, do you still know how such a file can be decontaminated once
> it has been added to Perforce?

I think that the trick was to add a packed version of the
"contaminated" file in the source code of the APC tools.

Well, with the forthcoming git move, that kind of problem should
disappear. We should probably get rid of all .packed files and add a
.gitattributes files at the root to record which files are binary.
(Versioned metadata. Yay)

PS. My @mandriva email address is dead since two years...
3) Rafael Garcia-Suarez Re: Warn on occluded global - question [PATCH]
| +1 vote
2008/11/17 Peter Scott <Peter@psdt.com>: I must admit that I see no compelling reason to add this...
Perl 5 Porters
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
2008/11/17 Peter Scott <Peter@psdt.com>:
> At 06:57 AM 11/17/2008, demerphq wrote:
>>
>> Im wondering tho, isnt part of your education that anything named with
>> ALLCAPS, or "punctuation style" is "special" and should be treated
>> specially and carefully?
>
> Except that I cite ALLCAPS early on as a best practice for naming
> constants...
>
> So, I return to the original question: If I beef this patch up to industrial
> strength, will it be accepted?

I must admit that I see no compelling reason to add this warning. It's
not extremely consistent, and not extremely useful.
4) Rafael Garcia-Suarez Re: [RFC] Regular expression character classes and unicode.
| +1 vote
2008/11/11 karl williamson <public@khwilliamson.com>: To me it's a bug. Actually that might be...
Perl 5 Porters
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
2008/11/11 karl williamson <public@khwilliamson.com>:
> But there are problems with pragmas. As I've discovered, the charnames
> pragma goes away in an eval. That this should happen was not obvious to me,
> and I suspect not so to the average Perl progammer. It doesn't DWIM, and
> I'm not convinced it is the right thing to do. It means that complementing
> the default from release to release can cause programs to have to add pragma
> calls to their evals.

To me it's a bug. Actually that might be caused by charnames storing
an arrayref in %^H. But I don't reproduce it with 5.10 (the script
below works). Do you have some test code ?

use strict;
use warnings;
use 5.01;
use charnames 'greek';
say "\N{sigma} is Greek sigma";
eval { say "\N{sigma} is Greek sigma"; };
eval ' say "\N{sigma} is Greek sigma"; ';
5) Rafael Garcia-Suarez Re: [perl #58428][PATCH] Unicode::UCD::charinfo() does not work on 21 Han codepoints
| +1 vote
2008/8/31 <renee.baecker@smart-websolutions.de>: Thanks, applied, and $VERSION bumped to 0.26....
Perl 5 Porters
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
2008/8/31 <renee.baecker@smart-websolutions.de>:
> Hi,
>
> attached is a patch for UCD.pm that reads the ranges from
> UnicodeData.txt.
>
> With this patch applied and the latest UnicodeData.txt
> (http://unicode.org/Public/UNIDATA/UnicodeData.txt), karl williamson's
> script works.

Thanks, applied, and $VERSION bumped to 0.26.

spacer
Profile | Posts (942)
Home > People > Rafael Garcia-Suarez