Grokbase
Topics Posts Groups | in
x
[ help ]

Re: t/op/regexp_unicode_prop_thr.t marked as binary in APC

View PostFlat  Thread  Threaded | < Prev - Next >
Nicholas Clark Re: t/op/regexp_unicode_prop_thr.t marked as binary in APC
| +1 vote
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
On Wed, Nov 19, 2008 at 10:29:32AM +0100, Rafael Garcia-Suarez wrote:
> 2008/11/19 Andreas J. Koenig <andreas.koenig.7os6VVqR@franz.ak.mind.de>:

> > Rafael, do you still know how such a file can be decontaminated once
> > it has been added to Perforce?
>
> I think that the trick was to add a packed version of the
> "contaminated" file in the source code of the APC tools.

In this case, I believe that I already fixed the metadata within perforce.

> Well, with the forthcoming git move, that kind of problem should
> disappear. We should probably get rid of all .packed files and add a
> .gitattributes files at the root to record which files are binary.
> (Versioned metadata. Yay)

I'm not convinced that that's reason alone.

Perforce, also, is quite capable of holding binary files, yet we've chosen
deliberately not to have any. I'm not sure of *all* of the reasons why, but
one of them is it useful having the mailed diffs being canonical, rather than
partial, because one can verify all the commits.

Nicholas Clark

Thread : t/op/regexp_unicode_prop_thr.t marked as binary in APC
1)
Andreas J. Koenig The APC had always troubles with files containing bytes with the high bit set. Consequently...
2)
Rafael Garcia-Suarez 2008/11/19 Andreas J. Koenig <andreas.koenig.7os6VVqR@franz.ak.mind.de>: I think that the trick was...
3)
Nicholas Clark In this case, I believe that I already fixed the metadata within perforce. I'm not convinced that...
4)
Rafael Garcia-Suarez 2008/11/19 Nicholas Clark <nick@ccl4.org>: I don't think that reason alone was sufficient to go...
5)
Abigail That's strange. The t/op/regexp_unicode_prop_thr.t I submitted wasn't supposed to have any...
6)
demerphq 2008/11/19 Abigail <abigail@abigail.be>: I can see the null byte at the end of the file. Yves...
7)
demerphq 2008/11/19 demerphq <demerphq@gmail.com>: I just redownloaded the file from your original mail, and...
8)
Andreas J. Koenig Could you fix that? Could you probably invent a new name and remove the broken one? That would...
9)
Nicholas Clark I did that two days ago. Nicholas Clark
spacer
View PostFlat  Thread  Threaded | < Prev - Next >