Grokbase
Topics Posts Groups | in
x
[ help ]

Re: File::Path regression in 5.8.9

View PostFlat  Thread  Threaded | < Prev - Next >
Nicholas Clark Re: File::Path regression in 5.8.9
| +1 vote
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
On Fri, Nov 14, 2008 at 11:59:22AM +0100, Gisle Aas wrote:
> On Nov 14, 2008, at 11:15 , Nicholas Clark wrote:
> >True. I considered this, but then we get back to a version with a CVE,
> >don't we?
>
> No. perl-5.8.8 shipped with File-Path-1.08 and the CVE-2008-2827 was
> introduced in the 2.xx series.

I believe we're back to code with CVE-2002-0435

> >I think I like the idea of reverting the detection code for now, and
> >then
> >repenting in leisure. Er, well, writing it properly in leisure.
> >
> >Am I right in thinking that if the detection code is reverted, the
> >behaviour
> >is no different (and hence no worse) than the behaviour of 5.8.8 ?
>
> Yes, it should be with that regard.

But we re-add a CVE, so going backwards is not a good option either.

I would be most happy if File::Path 2.08 removed the check code, and
2.09 re-added it, patched and fixed, and 5.8.9 shipped with 2.08

That way, if there are still lingering bugs in the check code, they don't
afflict everyone who is forced to use core releases only, and banned from
upgrading from CPAN.

Nicholas Clark

Thread : File::Temp / File::Path interaction
1)
Tim Jenness Debian bug http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=479317 reports that File::Temp and...
2)
Craig Berry I think rmtree now just warns rather than aborting. See:...
3)
David Golden I would go ahead and do that, even if File::Path is fixed since people might upgrade File::Temp and...
4)
Gisle Aas I don't think I would recommend that. File::Path actually tries to croak if you try do delete the...
5)
David Golden That's my point. There are possible reasons why temporary files/directories can't be deleted on...
6)
Gisle Aas That's fair enough. I just think it might be a bad idea to totally silence the rmtree() errors that...
7)
Tim Jenness That seems fine with me. I'll put together a new release.
8)
Dr.Ruud Gisle Aas schreef: eval { rmtree($dir); or do { $@ ||= sprintf "Unknown error in %s, line %s",...
9)
Jan Dubois The last item is typically caused by virus scanners too. You'll (used to) hit it with the core Perl...
10)
demerphq Jan Dubois <jand@activestate.com>: Would this still be a problem if the tempfile was opened with...
11)
David Golden That's kind of a different case. The one I mean is where ordinary Directory removal fails because...
12)
Gisle Aas I really do think this needs to be fixed before 5.8.9. Here is more proper test that works in...
13)
Nicholas Clark Sigh. You're probably right. So. Dear perl5-porters, if you want 5.8.9 this year, please propose a...
14)
Gisle Aas My proposed fix is to remove the code that tries to prevent deletion of an anchestor directory from...
paperclip
15)
Nicholas Clark True. I considered this, but then we get back to a version with a CVE, don't we? I think I like the...
16)
Gisle Aas No. perl-5.8.8 shipped with File-Path-1.08 and the CVE-2008-2827 was introduced in the 2.xx series....
17)
Nicholas Clark I believe we're back to code with CVE-2002-0435 But we re-add a CVE, so going backwards is not a...
18)
Gisle Aas No. File::Path has never had the problem described in CVE-2002-0435. It's a bit confusing that the...
19)
Nicholas Clark Thanks for that correction and clarification. So, I have it right that the security summary is...
20)
Gisle Aas That's right, but it's just a trivial patch to fix the issue in File::Path 2.07. In File::Path 1.08...
21)
Niko Tyni FYI, I just reopened the relevant Debian bugs <http://bugs.debian.org/286905> (allow creation of...
22)
Nicholas Clark Applied to blead as change 35008, with a version bump to 2.07_01 Nicholas Clark
23)
Marcus Holland-Moritz Potential patch attached. I'm trying to rely on File::Spec doing cross-platform things right, as I...
paperclip
24)
Marcus Holland-Moritz BTW, even though File::Path claims to work with 5.005_04, it won't run the test suite, due to...
25)
David Landgren Without looking at the code, that would be a test for a bugfix I added recently. It will be a...
26)
Nicholas Clark I *almost* applied this to blead, before re-reading the comment about VMS. I then started to...
27)
Craig Berry Sorry not to have been paying more attention. If I test mhx's patch against 2.07 on VMS and it all...
28)
Nicholas Clark Also my fault for not realising that I should have asked. Yes, but do it today please. bumps...
29)
Craig Berry Will do. Sounds reasonable. I'll be offline for a couple hours but will get to it as soon as I'm...
30)
Craig Berry Marcus's change is in as 35012 with the following slight modification: --- lib/File/Path.t;-1 Thu...
31)
Gisle Aas I'm still in favor of just removing the subdir test (change 35009) as this part is anyway totally...
32)
Craig Berry I don't have that strong a preference one way or the other -- I was just trying to respond to the...
33)
Nicholas Clark Yes, I was thinking that - can it produce a false positive? Also, given the convolutions needed in...
34)
Nicholas Clark Gah. And again I hit send too soon. I mean to add: And we have plenty of time to deliberate this,...
35)
Gisle Aas Yes, I think so. The current state of File::Path ought to be good enough for 5.8.9. I'm happy to...
spacer
View PostFlat  Thread  Threaded | < Prev - Next >