Grokbase
Topics Posts Groups | in
x
[ help ]

Re: Change 34882 (was Change 34822)

View PostFlat  Thread  Threaded | < Prev
Nicholas Clark Re: Change 34882 (was Change 34822)
| +1 vote
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
On Tue, Nov 18, 2008 at 10:29:50AM -0500, Jerry D. Hedden wrote:

> Nicholas Clark wrote:
> > No, you managed to add an ASCII NUL byte at the end:
> >
> > Hopefully fixed with 34883. Appended. Not that there's much diff :-)
>
> Nope. That didn't fix it. At least the contents for the missing file
> are not in the change file:
>
> ==== //depot/perl/t/op/regexp_unicode_prop_thr.t#2 (text) ====
>     Index: perl/t/op/regexp_unicode_prop_thr.t
> Binary files perl/t/op/regexp_unicode_prop_thr.t#1~34882~ and
> perl/t/op/regexp_unicode_prop_thr.t differ
>     End of Patch.
>
> Do I have to manually add this file to my system based on a snapshot archive?

Probably.

But I think it is fixed now, because if I edit the file now with perforce, I
get a text diff. I didn't before I submitted that change.

Note, I *didn't* get a text diff while my metadata change was unsubmitted.
Mmmm. I'd be curious why they don't consider that a bug. Then again, perforce
fails to version control metadata (certainly about permissions) when one
syncs forwards and backwards in history. *That* I feel is a bigger bug to fix.

But we won't be around to see it fixed.

Nicholas Clark

Thread : Re: Change 34882 (was Change 34822)
1)
Jerry D. Hedden Corrected the change number. > Continue? [n]...
2)
demerphq 2008/11/18 Jerry D. Hedden <jdhedden@cpan.org>: Hmm, I suspect that when i added the files I didnt...
3)
Nicholas Clark No, you managed to add an ASCII NUL byte at the end: $ od -a t/op/regexp_unicode_prop_thr.t 0000000...
4)
Jerry D. Hedden Nope. That didn't fix it. At least the contents for the missing file are not in the change file:...
5)
Nicholas Clark Probably. But I think it is fixed now, because if I edit the file now with perforce, I get a text...
spacer
View PostFlat  Thread  Threaded | < Prev