Grokbase
Topics Posts Groups | in
x
[ help ]

Re: Change 32016 breaks a test in MPEG::Audio::Frame

View PostFlat  Thread  Threaded | < Prev
Yuval Kogman Re: Change 32016 breaks a test in MPEG::Audio::Frame
| +1 vote
[ Profile | Reply to group ] [ Flat  Thread  Threaded ]
On Sun, Oct 19, 2008 at 17:29:46 +0100, Nicholas Clark wrote:

> It looks like a blessed glob because it is a blessed glob.
>
> Change 32016 fixed a bug which the implementation is relying on. The test does
> this:
>
>     tie *FH, 'MPEG::Audio::Frame', *DATA;
>
> which calls this:
>
> sub TIEHANDLE { bless \$_[1],$_[0] } # encapsulate the handle to save on unblessing and stuff

I'm an idiot, sorry.  I think I had only been doing Perl for like a
year back then though, so I'm cutting myself some slack ;-)

> There's actually no interaction with tie and overloading. It just happens that
> the class here uses both, and the bless happens to be concealed within the
> TIEHANDLE method.

I should probably redo that module with Moose and just clean it up.
Unfrotunately I'm low on tuits and motivation for that specific
module, but it seems clear to me that this is my fault and not
Perl's.

--
  Yuval Kogman <nothingmuch@woobling.org>
http://nothingmuch.woobling.org 0xEBD27418

Thread : Change 32016 breaks a test in MPEG::Audio::Frame
1)
Slaven Rezic The change 32016 (in maint-5.8: 32018) breaks the t/04-tie.t test in MPEG-Audio-Frame-0.09. It...
2)
Nicholas Clark Gosh. Your testing now on its own seems far more comprehensive than 5.10 ever got. This test fails...
3)
Nicholas Clark It looks like a blessed glob because it is a blessed glob. Change 32016 fixed a bug which the...
4)
Yuval Kogman I'm an idiot, sorry. I think I had only been doing Perl for like a year back then though, so I'm...
spacer
View PostFlat  Thread  Threaded | < Prev