I'm in the process of testing my changes to the IntakeService; nothing major
just some streamlining & cleanup stuff. However I would like the opinion of
those who have been using Intake for a while.
DefaultValidator is the base class for all validation classes.
NumberValidator extends this and seems to be THE validator class for all
numberFields (double etc) except int's which uses IntegerValidator which in
turn extends NumberValidator.
I'd like to clean this up and have (at least) thre options
A) If we drop NumberValidator then we get a validator class for each
different number type.
B) If we drop IntegerValidator we have one class for all number types based
on BigDecimals which I'm not keen on.
C) Combination of above
I have a preference for *A* where use can be made of primitive types
instead of BigDecimal for all. I could also look at making NumberValidator
Abstract and just implement what's needed in the concrete number classes.
Any opinions?
Colin
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
[Turbine-dev] IntakeService
| Tweet |
|
Search Discussions
Discussion Posts
Follow ups
- Quinton McCombs: Making NumberValidator abstract with concrete number classes +1 --------------------------------------------------------------------- To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
- Colin Chalmers: Hi, My changes to the IntakeService seems to have moved from a wee cleanup to a wee rework, introducing an abstract class for numbers supporting all primitive types and more use of inheritance where needed. I could post the UML diagram for the validator package but this will probably get rejected by mailList right? Anyone want to receive this drop me a line, would be good to get some feedback before I attempt to post diffs for checkin. This exercise has certainly enhanced my understanding of
- Henning P. Schmiedehausen: "Colin Chalmers" writes: +1. Anything that improves Intake is very welcome and gladly taken. Regards Henning -- Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/ Java, perl, Solaris, Linux, xSP Consulting, Web Services freelance consultant -- Jakarta Turbine Development -- hero for hire --------------------------------------------------------------------- To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org For
Related Discussions
Discussion Overview
| group | dev
|
| categories | turbine |
| posted | May 1, '03 at 6:49p |
| active | May 12, '03 at 1:38p |
| posts | 6 |
| users | 4 |
| website | turbine.apache.org |
