[Turbine-dev] IntakeService

Hi all,

Not sure if this is part of coding conventions or an oversight:

I was looking through some of the files in intake/validator package and
noticed that some properties were being *initialised* to null and/or 0
twice! And that some objects were being initialised outside the constructor,
something I try my best to avoid!!

For example, in the DefaultValidator class the property maskString is
implicitly set to null on line 243 and explicitly set to null on line 294.
Same applies to all properties of this class and to numerous if not all
classes of this package. In my opinion this is unnecessary. Personally I do
try to explicitly set Strings to null but here it's being set twice.

Perl5 -matcher & compiler (lines 258 & 261) are being initialised outside
the Constructor, would it not be better to move them into the init method?

If there is no explicit reason for these I'll post patches to the relevant
files the coming day or two.

Colin



---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org