FAQ

On 29/10/2014 20:03, Rémy Maucherat wrote:
2014-10-29 20:27 GMT+01:00 Mark Thomas <markt@apache.org>:
OK. Lets leave it in place until the issues with the tests are fixed.

The started flag being true for the MUST_COMPLETE state is causing
problems too. It breaks code like this:

if (request.isAsyncStarted()) {
request.getAsyncContext().complete();
}

While you could make the "effects of complete have to be delayed..."
argument, I don't think it holds in this case as the ability to test if
complete() needs to be called is more important.

What do you think about reverting that particular change?

It's the same thing, the started flag should be true until the end of the
processing of complete, which means for example for code like:
ac.complete();
println("" + ac.isAsyncStarted());

It should display "true" rather than "false".

I'll add the strict flag as well for that.
Thanks. I've just removed it :)

Adding the isCompleting() code and using it in the ErrorReportValve
appears to have fixed all the issues with the unit tests apart from the
ISE issues with get[Request|Response]() which are just issues with the
tests. I'll work on those next.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Search Discussions

Discussion Posts

Previous

Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 13 of 14 | next ›
Discussion Overview
groupdev @
categoriestomcat
postedOct 29, '14 at 5:29p
activeOct 29, '14 at 10:27p
posts14
users3
websitetomcat.apache.org
irc#tomcat

People

Translate

site design / logo © 2017 Grokbase