FAQ

On Mon, Aug 5, 2013 at 9:20 PM, Michael Paquier wrote:
On Fri, Aug 2, 2013 at 1:40 PM, Alvaro Herrera wrote:
That seems more mess than just keeping that function in postmaster.c.
I agree with moving the other one.
Please find attached a patch for that can be applied on master branch.
do_start_bgworker is renamed to StartBackgroundWorker and moved to
bgworker.c. At the same time, bgworker_quickdie, bgworker_die and
bgworker_sigusr1_handler are moved to bgworker.c as they are used in
do_start_bgworker.
This particular formulation doesn't seem quite good to me, because
we'd end up with a function called StartBackgroundWorker() and another
called StartOneBackgroundWorker() doing related but different things.
Maybe we can name things a bit better?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Search Discussions

Discussion Posts

Previous

Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 7 of 12 | next ›
Discussion Overview
grouppgsql-hackers @
categoriespostgresql
postedJul 28, '13 at 5:26a
activeAug 16, '13 at 7:32p
posts12
users4
websitepostgresql.org...
irc#postgresql

People

Translate

site design / logo © 2017 Grokbase