[PHP-INTERNALS] [RFC] Allow non-variable arguments to empty() and isset()

	Nikita Popov
	Apr 30, 2012 at 1:05 pm

On Mon, Apr 30, 2012 at 9:50 AM, Patrick ALLAERT wrote:
Hi,

2012/4/12 Nikita Popov <nikita.ppv@googlemail.com>:

PS: I added isset() too, to address the consistency concerns mentioned on IRC.

I would have voted +1 if it didn't contain the isset() change. None of
the examples used in the isset_with_expr.phpt test seems logic to me.

Care to explain the consistency concerns here?

Patrick

I changed the vote to have three options: "Both empty() and isset()",
"Only empty()" or "None"

https://wiki.php.net/rfc/empty_isset_exprs#vote

Nikita

Search Discussions

Discussion Posts

Nikita Popov: The concerns came from laruence, so maybe he could drop a comment here :) Basically, empty() and isset() are very similar in their nature, so changing only one of them might seem inconsistent. Personally I don't see much use in allowing expressions in isset(). People being confused by empty(trim($_GET['foo'])) not working is quite common, but I've never heard of somebody trying to use isset() on a function call. The name already makes clear that it's intended for use on variables. So, I'm not

Follow ups

Related Discussions

Discussion Navigation

view	thread \| post
posts	‹ prev \| 6 of 31 \| next ›

Discussion Overview

group	php-internals
categories	php
posted	Apr 12, '12 at 9:42p
active	May 5, '12 at 12:22p
posts	31
users	13
website	php.net

font	variable	Hotkey: f
user style	avatars	Hotkey: a

[PHP-INTERNALS] [RFC] Allow non-variable arguments to empty() and isset()

Search Discussions

Discussion Posts

Related Discussions

13 users in discussion

Content

People

Support

Translate